[#15702] - PHPDoc cleanup
- Closed
- 23 Jul 2018
- Medium
- Build: staging
- # 15702
- Diff
- demis-palma:phpdoc
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_cache com_installer com_joomlaupdate com_languages com_menus com_messages com_templates com_users Templates (admin) Front End com_config Libraries Plugins Templates (site) |
| Labels |
Added:
?
|
||
@brianteeman alignment done.
About non PHP document changes, If you refer to the parameter $startTime = 0.0 I did it to fix another inconsistency between the doc and the code.
The PHPdoc declares the variable as "double"
@param double $startTime
but the method initialises it with an "integer" value
$startTime = 0
gettype(0) returns "integer"
gettype(0.0) returns "double"
As far as I know, the correct way to initialise a "double/float" without using a cast, is using the decimal point.
But if you have other reasons, I can separate this last.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15702.
A pull request should have a single responsibility.
In this case, profiler restored.
Because some of the files were moved I updated this and created a new PR #21234.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15702.
can this PR be closed?
this PR can be closed.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-23 15:35:37 |
| Closed_By | ⇒ | rdeutz |
Can you remove the non php document changes from this PR and put them in their own PR please