[#15658] - [4.0] change BS2 classes
- Fixed in Code Base
- 28 Apr 2017
- Medium
- Build: 4.0-dev
- # 15658
- Diff
- brianteeman:bs2
User tests: Successful: Unsuccessful:
This is a first pass at making sure we arent using any bs2 classes
row-fluid -> row
btn-mini -> btn-xs
btn-small -> btn-sm
btn-large -> btn-lg
alert -> alert alert-warning
alert-error -> alert-danger
hidden-phone -> hidden-xs
hidden-tablet -> hidden-sm
muted -> text-muted
add-on -> input.group.addon
bar -> progress-bar
bar--> progress-bar-
span* -> col-md-*
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_config com_fields com_finder com_joomlaupdate com_languages com_media com_menus com_users Front End com_contact com_content com_newsfeeds Installation Layout |
| Labels |
Added:
?
|
||
| Category | Administration com_associations com_config com_fields com_finder com_joomlaupdate com_languages com_media com_menus com_users Front End com_contact com_content com_newsfeeds Installation Layout | ⇒ | Administration com_associations com_categories com_config com_fields com_finder com_joomlaupdate com_languages com_media com_menus com_users Front End com_contact com_content com_newsfeeds |
Ahh okies.
and I know it seems daft but there was no migration guide from 2 to 4
So I had to take everything to bs3 BEFORE I can look at changes from 3 to 4
as long as there are no typos in this PR can it be merged and then I can continue to work through other css class changes during the sprint at the weekend
Ok so if there are any elements with only hidden-xs, replace this with hidden-xs-down.
If there are any elements with hidden-xs and hidden-sm, replace both with just hidden-sm-down.
Other than that, please fix:
- Progress bar markup
- 2 other instances of
article-infotext-mutedwhere a space is needed.
Once done, this is ready to merge.
all requested changes made
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-28 16:33:37 |
| Closed_By | ⇒ | wilsonge |
Thanks :)
this is just a beginning but hd to start somewhere
Code review of this made me notice https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_fields/views/fields/tmpl/modal.php#L87-L97 :P So looks like i need to go search out conflicts
CF : https://getbootstrap.com/docs/4.0/migration/#buttons
Dropped the .btn-xs class entirely as .btn-sm is proportionally much smaller than v3’s.
Looks like the btn-xs should be migrated into btn-sm ; they are displayed as regular (big) buttons otherwise.
@ciar4n @C-Lodder