? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
28 Apr 2017

Pull Request for Issue #15549.

Summary of Changes

Changes the articles and featured models back to using the list.ordering state instead of the list.fullordering one. Added the new ordring options to the whitelist.

This also removes the check for the vote plugin from JFormFieldList because that class certainly shouldn't he to deal with that. Instead I created a new custom formfield class for com_content. The behavior of the respective parameters is exactly the same as before.

Testing Instructions

  • Test that ordering in the article and featured article manager works. Article manager by default should be ID Descending, featured one title ascending.
  • Test that sorting by votes and ratings works.

Expected result

Works

Actual result

Default is ID ascending for the article manager.

Documentation Changes Required

None. This restores previous behavior.

avatar Bakual Bakual - open - 28 Apr 2017
avatar Bakual Bakual - change - 28 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2017
Category Administration com_content Libraries
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Apr 2017

I have tested this item successfully on e570d2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15655.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 28 Apr 2017 - Tested successfully
avatar sseguin613
sseguin613 - comment - 28 Apr 2017

Test that ordering in the article and featured article manager works. Article manager by default should be ID Descending, featured one title ascending.

It is displaying by default as ID Ascending ,but the drop down box at the top is showing ID Descending.
capture

avatar Bakual
Bakual - comment - 28 Apr 2017

Hmm, that's strange, because when I try it it defaults to ID descending now both in the list and in the dropdown.

avatar Bakual
Bakual - comment - 28 Apr 2017

@sseguin613 Did you apply this PR before trying?

avatar sseguin613
sseguin613 - comment - 29 Apr 2017

I just applied the PR again and it is working as it should. I must have missed a file. Thank you for the quick fix. I can confirm it works as intended.

avatar Quy
Quy - comment - 29 Apr 2017

@sseguin613 When you have tested it successfully, please mark it here. Thanks.
https://issues.joomla.org/tracker/joomla-cms/15655

avatar sseguin613
sseguin613 - comment - 29 Apr 2017

I have tested this item successfully on e570d2d

Applied PR and issue corrected and functioning as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15655.

avatar sseguin613 sseguin613 - test_item - 29 Apr 2017 - Tested successfully
avatar ghazal
ghazal - comment - 29 Apr 2017

I have tested this item successfully on e570d2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15655.

avatar ghazal ghazal - test_item - 29 Apr 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Apr 2017

RTC after 3 successful tests.

avatar photodude
photodude - comment - 29 Apr 2017

@franz-wohlkoenig I don't believe it can be RTC when it's failing the code style check on drone.

avatar rdeutz rdeutz - change - 4 May 2017
Labels Added: ?
avatar rdeutz rdeutz - change - 5 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-05 08:08:25
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 5 May 2017
avatar rdeutz rdeutz - merge - 5 May 2017
avatar gwsdesk
gwsdesk - comment - 10 May 2017

I have tested this item successfully on e570d2d

avatar sharphosting
sharphosting - comment - 17 May 2017

Great to have this fixed (and so quickly). Thanks all.

Add a Comment

Login with GitHub to post a comment