Joomla! Issue Tracker | Joomla! CMS #15655

? ?

Fixed in Code Base
5 May 2017
Medium
Build: staging
# 15655
Diff
Bakual:FixVoteOrdering

Pending

User tests: Successful: Unsuccessful:

Bakual
28 Apr 2017

Pull Request for Issue #15549.

Summary of Changes

Changes the articles and featured models back to using the list.ordering state instead of the list.fullordering one. Added the new ordring options to the whitelist.

This also removes the check for the vote plugin from JFormFieldList because that class certainly shouldn't he to deal with that. Instead I created a new custom formfield class for com_content. The behavior of the respective parameters is exactly the same as before.

Testing Instructions

Test that ordering in the article and featured article manager works. Article manager by default should be ID Descending, featured one title ascending.
Test that sorting by votes and ratings works.

Expected result

Works

Actual result

Default is ID ascending for the article manager.

Documentation Changes Required

None. This restores previous behavior.

95dcb6a 28 Apr 2017

Fixing ordering by rating and rating_count (don't use fullordering!)

e570d2d 28 Apr 2017

Removing logic to check for the vote plugin from the JFormFieldList and add a custom formfield to handle that specific case.

Bakual - open - 28 Apr 2017

Bakual - change - 28 Apr 2017

Status

New

⇒

Pending

joomla-cms-bot - change - 28 Apr 2017

Category

⇒

Administration com_content Libraries

franz-wohlkoenig - comment - 28 Apr 2017

I have tested this item ✅ successfully on e570d2d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15655.}

franz-wohlkoenig - test_item - 28 Apr 2017 - Tested successfully

sseguin613 - comment - 28 Apr 2017

Test that ordering in the article and featured article manager works. Article manager by default should be ID Descending, featured one title ascending.

It is displaying by default as ID Ascending ,but the drop down box at the top is showing ID Descending.

Bakual - comment - 28 Apr 2017

Hmm, that's strange, because when I try it it defaults to ID descending now both in the list and in the dropdown.

Bakual - comment - 28 Apr 2017

@sseguin613 Did you apply this PR before trying?

sseguin613 - comment - 29 Apr 2017

I just applied the PR again and it is working as it should. I must have missed a file. Thank you for the quick fix. I can confirm it works as intended.