[#15650] - [4.0]Footer module
- Closed
- 28 Apr 2017
- Medium
- Build: 4.0-dev
- # 15650
- Diff
- brianteeman:footer
User tests: Successful: Unsuccessful:
Somewhere the sql code for creating the footer module got removed. I cant see where but as the footer module files are still present this puts the sql back
Testing Instructions
On a clean install before this PR the footer module is not present in the module manager but it can be seen in extensions discover
Apply the PR and the sql and the module will be present in the manager and not in the discover
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql |
Ok but the module code itself is still there
and for the record I can see why you dont need to use that module on a site but removing it just seems a b/c change that is for no real benefit
No B/C breaks as far as I can tell. The module itself still exists and will continue working when upgrading from 3.x to 4.0, however it won't be installed on fresh installations of 4.0
Which reminds me, the mod_footer directory needs removing too.
If you dont want it to be installed on a new j4 install then you need to remove the code from the repo. You cant just remove the sql. thats why you have to remove the directory ;)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-28 09:29:42 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
will submit a PR :)
This got purposely removed. We now use a custom module, allowing people to add any text