Feeling Lucky
?
?
[#15642] - Add test cases for JDate constructor demonstrating broken timezone handling
- Closed
- 7 May 2017
- Medium
- Build: staging
- # 15642
- Diff
- mbabker:JDate-BC-Break
User tests: Successful: Unsuccessful:
Summary of Changes
With 3.7, the internals of JDate are now terribly broken. The attempt to handle the PHP 7.1 B/C break of supporting microseconds has also caused internal damage to the timezone handling of the system. This PR demonstrates the broken timezone handling.
This is obviously not a complete PR to address the bug, simply one that should be used to ensure our issue is fixed. Whether this commit is combined into a final PR or merged separately is up to whomever acts on this.
Expected result
Tests pass
Actual result
Tests fail
Additional Resources
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
mbabker
- comment
- 7 May 2017
Closed in favor of bug fixing PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-07 21:05:52 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
Clearly the test fails which is the intended behaviour right now so this is all good