User tests: Successful: Unsuccessful:
Removed the if filterButton
condition for PHP loading of filter fields.
Why: In Joomla 3.6.5 in list views (backend) one could easily hide the button "Search Tools" but show the filter fields permanentely by sending the options filterButton
and filtersHidden
to the JLayout like this
echo JLayoutHelper::render('joomla.searchtools.default', array('view' => $this,
'options' => array('filterButton' => false, 'filtersHidden' => false)
));
'filterButton' => false
. Option 'filtersHidden
' is senseless./administrator/components/com_content/views/articles/tmpl/default.php
.echo JLayoutHelper::render('joomla.searchtools.default', array('view' => $this,
'options' => array('filterButton' => false, 'filtersHidden' => false)
));
In backend go to administrator/index.php?option=com_content&view=articles
You'll see no filter fields and no button. If you want check HTML source code that filters are not loaded at all.
Now the same test with Joomla 3.6.5 in line 46 if you're not convinced: https://github.com/joomla/joomla-cms/blob/3.6.5/administrator/components/com_content/views/articles/tmpl/default.php#L46
No button but filters are always visible.
Apply patch.
Try again in Joomla 3.7
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
if you remove that if statement thendo you also need to remove the code at line 41
No, because option 'filterButton' has highest priority in line
https://github.com/joomla/joomla-cms/pull/15634/files#diff-7fc57bb3a5e5ed4c711d5ea9fe03a5cfL62
If option 'filterButton' is not set we have a fallback to $showFilterButton, quasi a default setting. Otherwise the coder rules.
Title |
|
||||||
Labels |
Added:
?
|
I have tested this item
I've followed the instructions step by step. (Info: Line 59 is not longer correct. It move to line 67.) At the point were i should apply the patch i've got the error message: "The patch could not be applied because the repository is missing". So i couldn't finish the test.
@icampus
@Schmidie64 The user/repo has been deleted. You will have to manually apply the changes as outlined here: https://github.com/joomla/joomla-cms/pull/15634/files
Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-23 12:42:58 |
Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15634
closed as stated above.
if you remove that if statement thendo you also need to remove the code at line 41