? Pending

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
27 Apr 2017

Summary of Changes

  • Removed the if filterButton condition for PHP loading of filter fields.

  • Why: In Joomla 3.6.5 in list views (backend) one could easily hide the button "Search Tools" but show the filter fields permanentely by sending the options filterButton and filtersHidden to the JLayout like this

echo JLayoutHelper::render('joomla.searchtools.default', array('view' => $this, 
'options' => array('filterButton' => false, 'filtersHidden' => false)
)); 

27-04-_2017_17-31-57

  • Since Joomla 3.7 not only the button is hidden but also all filters THAT ARE NOT LOADED BY PHP at all. No chance to show the filters permanentely if option 'filterButton' => false. Option 'filtersHidden' is senseless.

Testing Instructions

echo JLayoutHelper::render('joomla.searchtools.default', array('view' => $this, 
'options' => array('filterButton' => false, 'filtersHidden' => false)
)); 
avatar bertmert bertmert - open - 27 Apr 2017
avatar bertmert bertmert - change - 27 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2017
Category Layout
avatar bertmert bertmert - change - 27 Apr 2017
The description was changed
avatar bertmert bertmert - edited - 27 Apr 2017
avatar brianteeman
brianteeman - comment - 27 Apr 2017

if you remove that if statement thendo you also need to remove the code at line 41

avatar brianteeman
brianteeman - comment - 27 Apr 2017

for reference the changes you want to revert are from #10090

avatar bertmert
bertmert - comment - 27 Apr 2017

if you remove that if statement thendo you also need to remove the code at line 41

No, because option 'filterButton' has highest priority in line
https://github.com/joomla/joomla-cms/pull/15634/files#diff-7fc57bb3a5e5ed4c711d5ea9fe03a5cfL62

If option 'filterButton' is not set we have a fallback to $showFilterButton, quasi a default setting. Otherwise the coder rules.

avatar bertmert bertmert - edited - 27 Apr 2017
avatar bertmert bertmert - change - 27 Apr 2017
The description was changed
avatar bertmert bertmert - edited - 27 Apr 2017
avatar rdeutz rdeutz - change - 27 May 2017
Title
Searchtools JLayout. Remove filterButton dependency for filters display
Searchtools JLayout. Remove B\C breaking filterButton dependency for filters display
Labels Added: ?
avatar Schmidie64 Schmidie64 - test_item - 23 Jul 2018 - Tested unsuccessfully
avatar Schmidie64
Schmidie64 - comment - 23 Jul 2018

I have tested this item ? unsuccessfully on 230db57

I've followed the instructions step by step. (Info: Line 59 is not longer correct. It move to line 67.) At the point were i should apply the patch i've got the error message: "The patch could not be applied because the repository is missing". So i couldn't finish the test.
@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15634.

avatar Quy
Quy - comment - 23 Jul 2018

@Schmidie64 The user/repo has been deleted. You will have to manually apply the changes as outlined here: https://github.com/joomla/joomla-cms/pull/15634/files

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 23 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Jul 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-07-23 12:42:58
Closed_By franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Jul 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Jul 2018

closed as stated above.

Add a Comment

Login with GitHub to post a comment