Feeling Lucky
[#1563] - Delete class modal from body of compoennt.php of protostar template
- Closed
- 14 Oct 2013
- Medium
- Build: master
- # 1563
- Diff
- Serhioromano:fix-component-modal
User tests: Successful: Unsuccessful:
There is no sense to have this class on the body. &tmpl=component is used usually to display content without extra formatting. But there is a special formating on .modal class. Here is how send main form looks in <iframe>.
And here how it looks without modal class.
The main idea is that if I want borders on the body or some other styles I can always connect my own CSS. And component should have minimalistic view.
Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.
As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta. If it is no longer valid then please can you close this issue. Otherwise please can you:
1) Open an item on the Joomlacode tracker in the appropriate area.
CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103
CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549
2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.