[#15607] - Track plugins being loaded to unique dispatchers
- Fixed in Code Base
- 5 Jul 2017
- Medium
- Build: staging
- # 15607
- Diff
- mbabker:unique-dispatcher
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12690
Summary of Changes
JPluginHelper::importPlugin() has a static tracking array that only allows a plugin to be loaded once, preventing the ability for plugins to be registered to anything but the first dispatcher that gets used. Change the method to track loaded plugins based on the dispatcher to allow custom imports.
Testing Instructions
See the issue for more information.
Expected result
Plugins imported to each unique dispatcher.
Actual result
Plugins are only loaded to the first dispatcher (generally the singleton from JEventDispatcher::getInstance()).
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
We just had even more static tracking in the helper than I accounted for. Should be fine now.
I have tested this item
looks good to me. Thanks @mbabker
@iv660 and @franz-wohlkoenig can you take a look here? Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15607.
@franz-wohlkoenig may you found some time to test this as you commented on the other issue too ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15607.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-05 15:55:06 |
| Closed_By | ⇒ | rdeutz |
hmm. did i something wrong?
To me it looks like:
