? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Apr 2017

This adds a role of toolbar and an aria-label of toolbar to the default admin toolbar used on most components.

(There may be other places that this needs to be applied as well which i did in another pr for 3.x and will hopefully be merged across but this one was definitely different and needed its own PR)

avatar brianteeman brianteeman - open - 26 Apr 2017
avatar brianteeman brianteeman - change - 26 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2017
Category Administration Language & Strings Layout
avatar ciar4n
ciar4n - comment - 26 Apr 2017

I have tested this item successfully on 10a3608

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15586.

avatar ciar4n ciar4n - test_item - 26 Apr 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 26 Apr 2017

Is toolbar used in frontend?

avatar infograf768
infograf768 - comment - 26 Apr 2017

For frontend config?

avatar C-Lodder C-Lodder - test_item - 26 Apr 2017 - Tested successfully
avatar C-Lodder C-Lodder - test_item - 26 Apr 2017 - Not tested
279117d 26 Apr 2017 avatar brianteeman typo
avatar brianteeman brianteeman - change - 26 Apr 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 26 Apr 2017

@infograf768 frontend config was handled in the other pr which will hopefully be merged for 3.x

avatar C-Lodder
C-Lodder - comment - 26 Apr 2017

I have tested this item successfully on 279117d

Based on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15586.

avatar C-Lodder C-Lodder - test_item - 26 Apr 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 27 Apr 2017

Can we RTC this?

avatar dgt41 dgt41 - change - 27 Apr 2017
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 27 Apr 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15586.

avatar wilsonge wilsonge - change - 27 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-27 17:56:02
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 27 Apr 2017
avatar wilsonge wilsonge - merge - 27 Apr 2017
avatar brianteeman
brianteeman - comment - 27 Apr 2017

Thanks

Add a Comment

Login with GitHub to post a comment