Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#15573] - Fix https://github.com/joomla/joomla-cms/issues/15569

? Pending

User tests: Successful: Unsuccessful:

avatar fevangelou
fevangelou
26 Apr 2017

Pull Request for Issue #15569

Summary of Changes

Fixed attribute checks.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar fevangelou fevangelou - open - 26 Apr 2017
avatar fevangelou fevangelou - change - 26 Apr 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2017
Category ⇒ Libraries
avatar PhocaCz
PhocaCz - comment - 26 Apr 2017

Tested and working OK:

before the change:
Before change
after the change:
After change

avatar wilsonge wilsonge - change - 26 Apr 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-04-26 16:54:17
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 26 Apr 2017
avatar wilsonge wilsonge - merge - 26 Apr 2017
avatar wilsonge
wilsonge - comment - 26 Apr 2017

Merging with two good tests. Thanks guys!

avatar ggppdk
ggppdk - comment - 26 Apr 2017

Yes, seems to be working properly for me too

avatar dgt41
dgt41 - comment - 26 Apr 2017

@ggppdk @wilsonge @fevangelou unfortunately there is one more bug here:
these 2 lines https://github.com/joomla/joomla-cms/blob/staging/media/system/js/fields/calendar.js#L805-L806
needs to be moved before https://github.com/joomla/joomla-cms/blob/staging/media/system/js/fields/calendar.js#L804

Or we have:

		if (this.params.showsTodayBtn) {
			row = createElement("div", this.wrapper);
			row.className = "buttons-wrapper btn-group";

and should be:

		row = createElement("div", this.wrapper);
		row.className = "buttons-wrapper btn-group";
		
                if (this.params.showsTodayBtn) {

Will make PR tomorrow, unless someone else is faster

Add a Comment

Login with GitHub to post a comment