PR-staging RTC

Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
25 Apr 2017

Pull Request for Issue https://twitter.com/joovlaki/status/856913614367752196 (because apparently we can only take issues submitted over twitter now).

Summary of Changes

Fixes a b/c break in JMenuItem when checking if params is set

Testing Instructions

Run isset(\JFactory::getApplication()->getMenu()->getActive()->params) on pages with and without a active menu item

Expected result

Code gives the correct result

Actual result

It doesn't

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 25 Apr 2017
avatar wilsonge wilsonge - change - 25 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2017
Category Libraries
avatar wilsonge wilsonge - change - 25 Apr 2017
Labels Added: PR-staging
avatar dgt41
dgt41 - comment - 25 Apr 2017

I have tested this item successfully on 867d283


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

avatar dgt41 dgt41 - test_item - 25 Apr 2017 - Tested successfully
avatar infograf768 infograf768 - alter_testresult - 27 Apr 2017 - dgt41: Tested successfully
avatar infograf768
infograf768 - comment - 27 Apr 2017

I have tested this item successfully on 08d4dc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

avatar infograf768 infograf768 - test_item - 27 Apr 2017 - Tested successfully
avatar infograf768 infograf768 - change - 27 Apr 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 27 Apr 2017

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15553.

avatar rdeutz rdeutz - change - 27 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-27 12:23:53
Closed_By rdeutz
Labels Added: RTC
avatar rdeutz rdeutz - close - 27 Apr 2017
avatar rdeutz rdeutz - merge - 27 Apr 2017

Add a Comment

Login with GitHub to post a comment