OK I can confirm this on code review. Seems like the code we added in as a b/c layer expects that you have 3 parameters (the first always being the resource, the second the mootools inclusion, 3rd the relative to media directory). Unfortunately as we are only injecting a single parameter here the b/c compatible code https://github.com/joomla/joomla-cms/blob/3.7.0/libraries/cms/html/html.php#L673-L676 isn't triggered and therefore we think we have an options array (which isn't - it's just a boolean) and everything falls apart

dear wilsonge ,
could you pls tell how to suppress this warning

-JHtml::script(JUri::base() . 'components/com_rentflat/assets/test.js', true);

+$options = array('framework' => true);
+JHtml::script(JUri::base() . 'components/com_rentflat/assets/test.js', $options);

This should do the trick for now.

@wilsonge what about a empty check too? So we do not pass that if we have empty arrays?

Maybe also

if (!is_array($options) || !is_array($attribs))

Should do the trick too as only one can also be passed.

I mean is if (!is_array($options) enough?

@wilsonge Dropping the test on $attribs fixed the problem for me indeed, ie
// B/C before 3.7.0 if (!is_array($options) /*&& !is_array($attribs) */) {

Can you do a PR @weeblr - currently not at a computer

Hi George, not really, I am struggling to fix all the issue on sites being updated. There is another B/C break associated with the changes in internal representation of the scripts. You have a B/C layer when adding a script, but because the internal representation has changed, when using $document->getHeadData(), the data returned also changed format, and this is breaking quite some code we have on the sites for enhanced caching.

Will try.

Here it is #15600

Thanks a lot

#15600 was already applied and I still get these errors. Any Eta? I'm on 3.7.3..
socialhour.club

@jeeperinaz can you please open a new Issue givin exact Informations as this is a closed one?