Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
16 Jul 2013

Remove "OR a.parent_id=0" which was accidentally reintroduced with a platform merge (8f0beaf).

This created a performance problem due to caching issues.
Tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31497

avatar Bakual Bakual - open - 16 Jul 2013
avatar eddieajau
eddieajau - comment - 18 Jul 2013

Based on the previous fix, this looks good to merge.

Compare with https://github.com/joomla/joomla-platform/blob/staging/libraries/joomla/access/access.php#L217

avatar infograf768 infograf768 - reference | - 19 Jul 13
avatar Bakual Bakual - close - 19 Jul 2013
avatar Bakual
Bakual - comment - 19 Jul 2013

Closing as it's merged.

avatar Bakual Bakual - head_ref_deleted - 19 Jul 2013
avatar langbogen
langbogen - comment - 2 Aug 2013

After upgrading from 2.5.11 to 2.5.14 non-super-users always get the error message:
de: JERROR_LOGIN_DENIED="Es gibt keinen Zugriff auf die privaten Seiten."
en: JERROR_LOGIN_DENIED="You cannot access the private section of this site."

I had to revert this change to get my site running again :(

avatar kevinmorrison
kevinmorrison - comment - 2 Aug 2013

Check in your Global Configuration under permissions and make sure the
groups you are having trouble with are set with site login allowed.

From: langbogen [mailto:notifications@github.com]
Sent: Friday, August 02, 2013 3:34 PM
To: joomla/joomla-cms
Subject: Re: [joomla-cms] Remove "OR a.parent_id=0" (#1554)

After upgrading from 2.5.11 to 2.5.14 non-super-users always get the error
message:
de: JERROR_LOGIN_DENIED="Es gibt keinen Zugriff auf die privaten Seiten."
en: JERROR_LOGIN_DENIED="You cannot access the private section of this
site."

I had to revert this change to get my site running again :(


Reply to this email directly or view it on
GitHub#1554 (comment)
.

avatar Bakual
Bakual - comment - 3 Aug 2013

Agree that this sounds more like an issue with your site settings than with the code.

avatar Mech7
Mech7 - comment - 7 Aug 2013

I can confirm this issue, the groups are set the registered group is allowed to login.

avatar Bakual
Bakual - comment - 7 Aug 2013

I tried to reproduce it in my testing enviroment and registered users can access registered content just fine. So unable to confirm.

Anyway, you need to create a new tracker item, otherwise nothing will get fixed at all. Create a tracker in the 2.5 Bugtracker (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=11410), write proper testing instructions how to reproduce the problem on a new installation and reference this PR there.

avatar langbogen
langbogen - comment - 27 Aug 2013

Thanks, that did the job. It was a faulty JEvents Migration from Joomla 1.5 to 2.5.

I fixed the table manually as described in http://docs.joomla.org/J2.5:Users_Cannot_Login_in_2.5.13
I created a new JEvents category first and then run this SQL:
SELECT * FROM jos_assets WHERE name like "com_jevents%"

The new category showed the correct parent_id and the migrated categories showed "0" - so I updated them to the correct one.

Add a Comment

Login with GitHub to post a comment