[#15537] - com_menus. External link. Add support for protocols viber and skype
- Closed
- 21 May 2017
- Medium
- Build: staging
- # 15537
- Diff
- bertmert:patch-13
User tests: Successful: Unsuccessful:
Pull Request for Issue #15534
Summary of Changes
Add support for uri schemes/protocols skype and viber for field link in menu item type external link.
Testing Instructions
-
Create new menu item of type External link.
-
Try to save links like
skype:vasya
skype://vasya
viber:+38099999999
viber://+38099999999 -
You'll get a warning "Save not permitted."
-
Apply patch.
-
Try again
Comments
To be discussed?
@brianteeman mentioned correctly "skype is only in the provisional list of supported uri schema in the standards and viber is not in the list at all" at https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml in his comment #15534 (comment)
But see my comment, too: #15534 (comment)
So, I don't know...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
|
||
I am not in favour of this PR.
Closing because of lack of interest from issue opener since 4 weeks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-21 10:16:06 |
| Closed_By | ⇒ | bertmert |
I have tested this item✅ successfully on 887b41f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15537.