? ? Failure

User tests: Successful: Unsuccessful:

avatar alikon
alikon
25 Apr 2017

Pull Request for Issue #14959 .

Summary of Changes

moved actions from config.xml to access.xml

Testing Instructions

Users->Manage->Advanced Permissions Report

Expected result

after

Actual result

before

avatar alikon alikon - open - 25 Apr 2017
avatar alikon alikon - change - 25 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2017
Category Administration com_cache
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Apr 2017

I have tested this item successfully on f52c85f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15524.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Apr 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Apr 2017

This PR only resolves the issue identified in #14959 for one component. there are more than com_cache effected

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Apr 2017

Re-opened #14959

avatar alikon
alikon - comment - 25 Apr 2017

can you list the other's please

avatar brianteeman
brianteeman - comment - 25 Apr 2017

Just work through the select list - it is almost everything that is listed there that is NOT a traditional component like content eg Ajax, Content history, categrories etc

avatar alikon
alikon - comment - 25 Apr 2017

yes i see now ....

avatar brianteeman
brianteeman - comment - 25 Apr 2017

it does look like you correctly found the reason - I had failed in that search

avatar jsubri
jsubri - comment - 25 Apr 2017

Works fine for the 2 below views, however only when the filtering is on for Cache
administrator/index.php?option=com_users&view=debuguser&user_id=851
administrator/index.php?option=com_users&view=debuggroup&group_id=10
Without filtering we have the previous display, is it the expected behavior?

avatar alikon
alikon - comment - 26 Apr 2017

i'm not sure what should be the correct behavior without filtering, cause you may have different item's listed,
so the action that can be correct for an item (for example an article) cannot be correct for another one (for example com_cache)

avatar rdeutz rdeutz - change - 27 May 2017
Labels Added: ?
avatar roland-d
roland-d - comment - 12 Jul 2017

@alikon Can you elaborate on what the issue is?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15524.

avatar alikon
alikon - comment - 13 Jul 2017

this pr fix the list of permissions showed when the com_cache is selected (i.e ony the permission related to com_cache (core.admin,core.manage))

but if you don't select a component, the list of permission showed are general permissions
permission

in addition as @brianteeman #15524 (comment) pointed out, we stil need to manage componen'ts like com_ajax, com_contenthistory, etc.

avatar roland-d
roland-d - comment - 29 Aug 2017

@alikon Thank you for the explanation. Are you planning to do the other components in this PR as well or are we going to get a separate PR for each extension?

avatar alikon
alikon - comment - 31 Aug 2017

imo the latter should be a better way

avatar jsubri jsubri - test_item - 5 Sep 2017 - Tested successfully
avatar jsubri
jsubri - comment - 5 Sep 2017

I have tested this item successfully on d5902e1

Tested on 3.8RC1, this is fixing the com_cache when filtering is on.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15524.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 26 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

I have tested this item successfully on d5902e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15524.

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - merge - 18 Nov 2017
avatar mbabker mbabker - change - 18 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-18 15:57:30
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Nov 2017

Add a Comment

Login with GitHub to post a comment