[#15521] - [3.7.0+] [com_fields] modal untranslated strings
- Closed
- 20 Aug 2017
- Medium
- Build: master
- # 15521
Steps to reproduce the issue
install 3.7.0
create some custom fields
go to frontend and login as a user
fake editing an article and clicking the field button in tinyMCE by just loading the URL (with a valid token in the url):
in a WIDE MONITOR so that the ORDERING and ORDER LIMIT dropdowns are shown.
Note that in normal use this url is loaded in a modal window and css breakpoints HIDE the ordering/limit dropdowns.
Expected result
That all text strings are translated
Either
- Translate the strings
or - Remove the dropdowns that are being hidden by breakpoints in screen width caused by modal
Actual result
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
franz-wohlkoenig
- | Category | ⇒ | com_fields Language & Strings |
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Status | New | ⇒ | Discussion |
I disagree, anything that is rendered out in the DOM of a page should be correctly translated, even if that element is hidden by css or screen size breakpoints.
3pd are well known for reusing "core" features and so if a 3pd reused this view in a different way the width of a modal might be different, and show these useful filters, and they would be untranslated.
The un translated strings would also be logged during debugging
Well, I then guess it is just a matter of adding these strings in frontend.
Tested
Debug language displays in this case
# JROOT/administrator/components/com_fields/helpers/fields.php
JGLOBAL_FIELD_GROUPS="FIELD GROUPS"
# JROOT/libraries/joomla/form/fields/list.php
JGLOBAL_SORT_BY="SORT BY"
JGLOBAL_TITLE_ASC="TITLE ASC"
JGLOBAL_TITLE_DESC="TITLE DESC"
JGRID_HEADING_ACCESS_ASC="HEADING ACCESS ASC"
JGRID_HEADING_ACCESS_DESC="HEADING ACCESS DESC"
JGRID_HEADING_ID_ASC="HEADING ID ASC"
JGRID_HEADING_ID_DESC="HEADING ID DESC"
JGRID_HEADING_LANGUAGE_ASC="HEADING LANGUAGE ASC"
JGRID_HEADING_LANGUAGE_DESC="HEADING LANGUAGE DESC"
JGRID_HEADING_ORDERING_ASC="HEADING ORDERING ASC"
JGRID_HEADING_ORDERING_DESC="HEADING ORDERING DESC"
JSTATUS_ASC="ASC"
JSTATUS_DESC="DESC"
# JROOT/libraries/cms/layout/file.php
JTOGGLE_HIDE_SIDEBAR="HIDE SIDEBAR"
JTOGGLE_SHOW_SIDEBAR="SHOW SIDEBAR"
but it gets worse as "Field Group" is displayed 3 times in the dropdown.
Therefore, just adding the strings may not be the correct way to do.
brianteeman
- | Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-20 11:40:07 |
| Closed_By | ⇒ | brianteeman |
So, if I understand well, you are forcing loading in a normal window what should be in a modal .
I would not consider this as a bug.