Feeling Lucky
?
[#15499] - Fix for issue #15498
- Fixed in Code Base
- 24 Apr 2017
- Medium
- Build: staging
- # 15499
- Diff
- wilsonge:fix-content-router
User tests: Successful: Unsuccessful:
Pull Request for Issue #15498 .
Summary of Changes
It's bad practice to typehint against a stdClass instance. Instead it's better to check we don't get null back from JMenu::getActive or JMenu::getItem
Testing Instructions
Install staging with sample testing data. Go to the featured articles page. Before patch the home page has a url like JROOT/index.php/19-sample-data-articles/joomla/24-joomla. After the patch it should be JROOT/index.php
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
Kubik-Rubik
- comment
- 24 Apr 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15499.
dgt41
- comment
- 24 Apr 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15499.
| Status | Pending | ⇒ | Ready to Commit |
wilsonge
- comment
- 24 Apr 2017
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15499.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-24 10:22:05 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 87ba5af
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15499.