[#15492] - [com_fields] Escape checkboxes/radio option's text
- Closed
- 13 Aug 2017
- Medium
- Build: staging
- Easy Test
- # 15492
- Diff
- Quy:patch-7
User tests: Successful: Unsuccessful:
Summary of Changes
Option's value is escaped, but not the option's text which it should be.
Testing Instructions
Create checkboxes and radio custom fields with A&B for the text/value.
Edit an article.
View page source.
Find A&B.
Expected result
A&B
Actual result
A&B
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
| Category | Layout | ⇒ | com_fields Layout |
Forgot to mention that while doing the fresh installation for this PR this happened, but I'm guessing it is unrelated to this PR:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15492.
Good catch! Unfortunately, it is related to this pr. I will check it out.
Aaah ok nice, then good thing I spotted it :)
I have tested this item
With and -out PR got A&B in Pagesource.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15492.
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
RTC after two successful tests.
Please remove RTC for now as it affects the installation as discovered above which needs to be fixed. Thanks.
| Status | Ready to Commit | ⇒ | Pending |
Set back on pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15492.
@Quy gentle reminder this needs updating
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15492.
| Category | Layout com_fields | ⇒ | Layout |
I will close it for now.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-13 21:05:14 |
| Closed_By | ⇒ | Quy |
I have tested this item✅ successfully on 9b0c82d
The options value and text are both correctly escaped as you can see:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15492.