If you review code, please ignore the ugly code in the banner module which register component autoloader. Once the autoload PR from @laoneo merged, we can remove that ugly code

I have tested this item ? unsuccessfully on f3d97d6

In banners found no problems adding, deleting, editing, publishing and unpublishing items, however on clients found problems adding or editing a client (no problems publishing/unpublishing, archiving and deleting clients):

Also found another problem unpinning banners:

Many thanks for testing @rjcf18. There were some typos and I fxied it. Please help testing it again

Regarding the Tracks, according to your screenshot, it is downloaded properly :)

No problem. Let me test it again ;)

I have tested this item ✅ successfully on 8e3c24c

Tested everything in banners and clients, no longer any problems, banner on frontend working, tracks exporting also working well. Everything seems to be fixed now.

Many thanks again for testing Ricardo.

No problem :)

I have tested this item ? unsuccessfully on 8e3c24c

> 5. Access to frontend, click on Banner link in All Modules module. There will be a banner displayed, click on it, see that it works

At this Step got: Fatal error: Class 'Joomla\Component\Banners\Administrator\Helper\BannersHelper' not found in /Applications/MAMP/htdocs/J4/administrator/components/com_banners/helpers/banners.php on line 17

Could you please let me know exactly on what step you get this error? Right after you click on Banner link in All Modules or click on the banner ?

Right after click on "Banner"-Link in "All Modules".

Strange. It works well here for me. Could you please zip the folder modules\mod_banners in your install and attach it here so that I can take a look? I am thinking that there might be some old files left and it causes the issue

Or if it is possible, please download a fresh copy of my branch https://github.com/joomdonation/joomla-cms/tree/namespace_com_banners , install and test it (just need to start from step #5 to save time)

Thanks for help testing

mod_banners.zip

The module you sent me is still using the old code, that explains why it doesn't work for you. See the the code of new file https://github.com/joomdonation/joomla-cms/blob/namespace_com_banners/modules/mod_banners/mod_banners.php

Maybe patchtester doesn't work well. Please install a copy of my branch https://github.com/joomdonation/joomla-cms/tree/namespace_com_banners and help testing it again

Installing your branch got:

I didn't have that problem. It may very likely be a patchtester problem, I used git and cloned this PR, did a fresh installation and found no problems, everything works fine.

@franz-wohlkoenig Please give it a final try

1. Option 1 : Replace the modules/mod_banners folder on your install with the module I attached here

2. Or download my branch again https://github.com/joomdonation/joomla-cms/archive/namespace_com_banners.zip (I just synchronized with 4.0-dev brach), install and test it

Hmm, for some reason, the zip module could not be uploaded. So I think the easiest way would be download my branch https://github.com/joomdonation/joomla-cms/archive/namespace_com_banners.zip , install and test it

Will test on your branch.

Thanks. I downloaded, tested and make sure it is installed properly :)

I have tested this item ✅ successfully on d22ae78

Thanks. Please mark this as ready to commit as we now have two successful tests. Look like the test result from Ricardo was reset for some reasons

@wilsonge This can be merged now. I will take care of necessary changes once autoload PR is merged (just need to remove some lines of code from the module)

RTC after two successful tests.

My test results were for a previous commit thats why it looks like it was reset :)

Thanks all :)

Thanks :)