Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#15479] - Fix wrong url generated for com_tags

? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
22 Apr 2017

Pull Request for Issue #15336

Summary of Changes

Fix wrong way to generate urls for Tags.
Sibling tag alias can not be used for other tag name.

Build url process should not base on current active menu.

Testing Instructions

Take a look at issue #15336

Expected result

Correct URL without additional menu alias which is not related with current URL.

Actual result

Wrong generated URL where unrelated menu alias was appended. See #15336

Documentation Changes Required

No

avatar csthomas csthomas - open - 22 Apr 2017
avatar csthomas csthomas - change - 22 Apr 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2017
Category ⇒ com_tags Front End Libraries Unit Tests
avatar csthomas csthomas - change - 22 Apr 2017
Labels Added: ? ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Apr 2017

I have tested this item ✅ successfully on f66a6eb

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15479.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 23 Apr 2017 - Tested successfully
avatar wilsonge
wilsonge - comment - 25 Apr 2017

Would this happen to fix #11163 ?

avatar csthomas
csthomas - comment - 25 Apr 2017

No, but I'm working on #11163 too in separate PR (add language to tag route #15539).

This PR #15479 fix problem with active menu item which create a mess on build process.

avatar korneliusz401
korneliusz401 - comment - 10 Aug 2017

I did not manage to apply the patch. I receive an error:
The file marked for modification does not exist: libraries/cms/router/site.php

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15479.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Aug 2017

@korneliusz401 there is an conflicting File (you can see it at the Bottom) which has to be resolved by @csthomas or a Maintainer.

avatar korneliusz401
korneliusz401 - comment - 11 Aug 2017

Thank you for your quick reply.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15479.

avatar csthomas
csthomas - comment - 22 Sep 2017

I will open it later when needed. For now this has a conflict with my other PR #17746

avatar csthomas csthomas - change - 22 Sep 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-09-22 12:35:11
Closed_By ⇒ csthomas
avatar csthomas csthomas - close - 22 Sep 2017
avatar csthomas csthomas - change - 24 Oct 2017
Status Closed ⇒ New
Closed_Date 2017-09-22 12:35:11 ⇒
Closed_By csthomas ⇒
avatar csthomas csthomas - change - 24 Oct 2017
Status New ⇒ Pending
avatar csthomas csthomas - reopen - 24 Oct 2017
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2017
Category com_tags Front End Libraries Unit Tests ⇒ com_tags Front End
avatar csthomas
csthomas - comment - 26 Oct 2017

@korneliusz401
@etnevel-dob
@absillitoe

This PR is open again and it's ready to test.
To test it, you can download one file components/com_tags/router.php from https://raw.githubusercontent.com/csthomas/joomla-cms/74ce4a96ecd5f4d42322e4eb57263c2ee0cf5b38/components/com_tags/router.php and replace in your joomla.

You can mark PR as tested at https://issues.joomla.org/tracker/joomla-cms/15479

avatar csthomas
csthomas - comment - 29 Oct 2017

This temporary does not work

avatar csthomas csthomas - change - 29 Oct 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-10-29 12:35:20
Closed_By ⇒ csthomas
Labels Removed: ?
avatar csthomas csthomas - close - 29 Oct 2017

Add a Comment

Login with GitHub to post a comment