? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
21 Apr 2017

Pull Request for Issue #15440 .

Summary of Changes

Restore deprecated code, this should be removed in J4 not yet!

Testing Instructions

Review the code!

Expected result

Actual result

Documentation Changes Required

@rdeutz

avatar dgt41 dgt41 - open - 21 Apr 2017
avatar dgt41 dgt41 - change - 21 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2017
Category Libraries
avatar dgt41 dgt41 - change - 21 Apr 2017
Labels Added: ?
avatar rdeutz
rdeutz - comment - 21 Apr 2017

could you @avjoomla test if the fix solves the problem

avatar infograf768
infograf768 - comment - 21 Apr 2017

Release Blocker?

avatar rdeutz
rdeutz - comment - 21 Apr 2017

@infograf768 we need to test and merge before release

avatar infograf768
infograf768 - comment - 21 Apr 2017

Tested that it does not break the new calendar (just to be sure). I do not have a sample code to test the original issue.

avatar wilsonge
wilsonge - comment - 21 Apr 2017

Added release blocker tag

avatar rdeutz rdeutz - change - 23 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-23 10:29:12
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 23 Apr 2017
avatar rdeutz rdeutz - merge - 23 Apr 2017
avatar avjoomla
avjoomla - comment - 25 Apr 2017

Just installed a new installation of Joomla! 3.7 as released today.
Sadly there are to typos in the code which was merged into the behavior.php with PR #15441

Line 381 (wrong)
JHtml::('stylesheet', 'system/calendarjos.css', array('version' => 'auto', 'relative' => true), $attribs);
correct:
JHtml::
('stylesheet', 'system/calendar-jos.css', array('version' => 'auto', 'relative' => true), $attribs);

Line 383 (wrong)
JHtml::('script', $tag . '/calendarsetup.js', array('version' => 'auto', 'relative' => true));
correct
JHtml::
('script', $tag . '/calendar-setup.js', array('version' => 'auto', 'relative' => true));

In both cases the file name is incorrect, the minus characters in file names are missing.

Regards,
Aicha


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15441.
avatar zero-24
zero-24 - comment - 25 Apr 2017

Can you please send that as PR against staging?

Add a Comment

Login with GitHub to post a comment