? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
21 Apr 2017

Namespace the router libraries.

Testing instructions

  • Create some nested categories
  • Create some articles in different categories
  • Create different article menu items
  • On the front, browse these menu items and navigate around

Expected result

All should work as without the patch.

avatar laoneo laoneo - open - 21 Apr 2017
avatar laoneo laoneo - change - 21 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2017
Category Libraries
5ec1e9c 21 Apr 2017 avatar laoneo cs
avatar laoneo laoneo - change - 21 Apr 2017
Labels Added: ?
avatar laoneo
laoneo - comment - 21 Apr 2017

Router must be namespaced in Joomla 4 because of the global constants in the JRouter class.

avatar laoneo laoneo - change - 21 Apr 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-04-21 17:24:08
Closed_By laoneo
avatar laoneo laoneo - close - 21 Apr 2017
avatar laoneo laoneo - change - 9 May 2017
Status Closed New
Closed_Date 2017-04-21 17:24:08
Closed_By laoneo
avatar laoneo laoneo - change - 9 May 2017
Status New Pending
avatar laoneo laoneo - reopen - 9 May 2017
avatar laoneo
laoneo - comment - 9 May 2017

Moved the constants to the import file to be always available.

avatar laoneo laoneo - change - 9 May 2017
The description was changed
avatar laoneo laoneo - edited - 9 May 2017
avatar laoneo laoneo - change - 9 May 2017
The description was changed
avatar laoneo laoneo - edited - 9 May 2017
avatar weeblr
weeblr - comment - 15 May 2017

Hi @laoneo

Tested this patch agains 3.8-dev + latest sh404SEF. No issue for main features.

avatar wilsonge wilsonge - close - 18 May 2017
avatar wilsonge wilsonge - merge - 18 May 2017
avatar wilsonge wilsonge - change - 18 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-18 21:52:09
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment