[#15436] - Allow Reverse Proxies to do the SSL for Joomla
- Closed
- 9 Apr 2020
- Medium
- Build: staging
- # 15436
- Diff
- nuncanada:staging
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Changed tests wether to create HTTPS links to also include a check for the header HTTP_X_FORWARDED_PROTO.
Testing Instructions
Configure your server to add a header HTTP_X_FORWARDED_PROTO "https"
With nginx:
proxy_set_header X-Forwarded-Proto $thescheme;
Expected result
Links created by joomla should use the HTTPS protocol
Actual result
They are created using HTTP protocol, because that is the protocol used by the Reverse Proxy to access the Joomla machine.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries External Library |
@nuncanada do you want to implement the requested changes? Or should we take care of the needed changes?
As far as I can tell this has already been fixed. @HLeithner if you could check and then if I was right close this it would be great
Thanks @brianteeman this is already fixed but only partly. I created a new pr #28618 to fix the rest
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-09 12:33:16 |
| Closed_By | ⇒ | HLeithner |
| Category | Libraries External Library | ⇒ | Libraries External Library Composer Change |
Hi,
please revert the change in the vendor folder and contribute that to the upstream framework repo: https://github.com/joomla-framework/application
Please also take a look into the conflicts with your branche. This is not testable nor mergable in this state :) let me know if you need any kind of help with that.