? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
20 Apr 2017

Summary of Changes

Fixes the styling of links in the contact view

Testing Instructions

Install J4 with sample data and check the single contact view menu item links tab

Expected result

screen shot 2017-04-20 at 14 35 43

Actual result

screen shot 2017-04-20 at 14 39 04

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 20 Apr 2017
avatar wilsonge wilsonge - change - 20 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2017
Category Front End com_contact
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Apr 2017

I have tested this item successfully on 2574669


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15429.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Apr 2017

@C-Lodder is "approved these changes" like a successfully Test?

avatar C-Lodder
C-Lodder - comment - 20 Apr 2017

@franz-wohlkoenig - code review

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Apr 2017

@brianteeman count a "approved by Code review" as successfully Test?

avatar brianteeman
brianteeman - comment - 20 Apr 2017

No

avatar brianteeman
brianteeman - comment - 20 Apr 2017

Well unless its the type of PR that can only be tested by code review which is rare. In general we need to have real world tests by users in their browsers not in their IDE

avatar rjcf18
rjcf18 - comment - 20 Apr 2017

I have tested this item successfully on 2574669

The single contact view menu item links tab is displayed correctly according to the changes made.

Before patch:
deepinscreenshot20170421001949

After patch:
deepinscreenshot20170421001959


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15429.

avatar rjcf18 rjcf18 - test_item - 20 Apr 2017 - Tested successfully
avatar wilsonge wilsonge - change - 20 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-20 23:31:18
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 20 Apr 2017
avatar wilsonge wilsonge - merge - 20 Apr 2017

Add a Comment

Login with GitHub to post a comment