[#15427] - Fixed calendar field hint
- Fixed in Code Base
- 27 Apr 2017
- Medium
- Build: staging
- Easy Test
- # 15427
- Diff
- demis-palma:calendar
User tests: Successful: Unsuccessful:
The code to display hint property in calendar fields is there, but it doesn't work.
Testing Instructions
Create a new (or modify an existing) calendar field, in the front-end or backend, and ensure to assign it a "hint" property, as shown in the picture:
I have temporary modified the calendar fields already present in Article Manager, to save me a lot of time.
Before the patch, the hint does not show.
After the patch, the hint is there.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Easy | No | ⇒ | Yes |
| Title |
|
||||||
| Title |
|
||||||
| Category | Layout | ⇒ | com_fields Layout |
| Category | Layout com_fields | ⇒ | Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15427.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
| Category | Layout | ⇒ | com_fields Layout |
| Category | Layout com_fields | ⇒ | Layout |
RTC after two successful tests.
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-27 12:47:47 | ||||
| Closed_By | ⇒ | wilsonge | |||||
| Labels |
Added:
?
?
|
||||||
@OctavianC nice spot. For what I know, the hint can be set only in the XML, and in no case it holds user inputs. So it does not causes security issues unless hacked by a site administrator, but, again,
"Hacking yourself is not hacking".
No. You can set the hint when you create the field in the UI
The Placeholder is only set by xml/admin so yes - "comes under hack yourself"
However, yes, it should be escaped, because even after this patch if you place a placeholder of:
enter a "birth date" here
then it would break and only show
enter a
I'll do a quick PR
I have tested this item✅ successfully on 453cfea
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15427.