[#15414] - Correcting Hathor postinstall message
- Fixed in Code Base
- 19 Apr 2017
- Medium
- Build: staging
- # 15414
- Diff
- infograf768:correct_hathor_message
User tests: Successful: Unsuccessful:
This corrects 2 issues:
- The code loading language would never load another language than en-GB (if the string is present) after a successful change of template via the postinstall message
- Typo in the language constant
TLPinstead ofTPL(this will be forwarded to TTs).
Test instructions
Install staging.
Install French Language https://github.com/infograf768/fr-FR-3.x/releases/download/v3.7.0.1.RC3/fr-FR_joomla_lang_full_3.7.0v1.zip
Switch template to Hathor and admin language to French
Go to administrator/index.php?option=com_postinstall
Click on the button to switch to Isis.
The success message will be in English.
Now patch, AND replace the string
TLP_HATHOR_CHANGED_DEFAULT_TEMPLATE_TO_ISIS="Le style de template administrateur vient d'être changé en '%s'"
to
TPL_HATHOR_CHANGED_DEFAULT_TEMPLATE_TO_ISIS="Le style de template administrateur vient d'être changé en '%s'"
in the /administrator/language/fr-FR/fr-FR.tpl_hathor.ini
switch to Hathor in the template manager and back to postinstall messages.
Click in the button to switch to Isis
You will now get a correct success message
correctly:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Templates (admin) |
The problem is that if we do not change it now, we never will and someone will make a PR to change that, and we will be forced to make a new string...
Now, if it is decided so, I have no issue to NEVER correct that constant until Hathor's death and limit the patch to the lang load
and, btw, we were already in lang freeze when this postinstall message was merged...
I have tested this item
Patch ok for me.
Please add it on 3.7.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15414.
I have tested this item
Tested the patch with multiple languages and it works fine now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15414.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-19 15:42:17 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Either we are or we are not in language freeze. That part of this PR should really wait until after the language freeze. It is not necessary to change the string to fix the genuine bug