[#15403] - add default params for the Integer field type on install
- Fixed in Code Base
- 19 Apr 2017
- Medium
- Build: staging
- # 15403
- Diff
- brianteeman:custom-fields-params
User tests: Successful: Unsuccessful:
Pull Request for Issue #15394 .
Summary of Changes
make sure that the integer field type is usable
Testing Instructions
BEFORE PR
On a Clean install
Create a content field of type integer. DO not set any values in the First, Last or Step fields
Try to use the field in an article
Expected result
The field has the first, last and step values from the plugin of 1, 100, 1
Actual result
The field can not be used
This PR
This PR insures that the default values of 1,100,1 are set for the params in the database on install.
Testing
This cannot be tested with com_patchtester as it just modifies the sql file that is run on install.
You can test it by manually inserting
{"multiple":"0","first":"1","last":"100","step":"1"} in the params field for plg_fields_integer in the #__extensions table
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql MS SQL |
At least one test would good before we merge it
will test in a couple of Minutes.
| Labels |
Added:
?
|
||
- applied
{"multiple":"0","first":"1","last":"100","step":"1"}in params of plg_fields_integer - new Field "Integer" > Dropdown isn't clickable.
in the extensions table?
sorry, wrong Table. In "_extensions" i can't find a plg_fields_integer-Field and dont know how to append it.
If you dont have a record for the plugin then you have done something very wrong with your install
Don't we also need to add that to the initial update sql file?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15403.
@brianteeman Tobias means here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/sql/updates/mysql/3.7.0-2016-08-29.sql#L84
and in the respective other two files.
That is needed for updates, the one you did is for new installs which is of course needed as well.
got it - update coming
Yes, that will work since we don't support (yet) updating from RCs.
| Category | SQL Installation Postgresql MS SQL | ⇒ | SQL Administration com_admin Postgresql MS SQL Installation |
I have tested this item
Tested on MySQL only.
Did a clean install and worked as expected.
Did the upgrade and manually ran the update sql in phpMyAdmin.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15403.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-19 18:54:35 |
| Closed_By | ⇒ | rdeutz |
thanks
@rdeutz @zero-24 This really needs to be merged into 3.7.0 or the integer field is pretty useless