? ? Success

User tests: Successful: Unsuccessful:

avatar jdolinski
jdolinski
18 Apr 2017

Pull Request for Issue # .

Summary of Changes

Added support for Redis session handling.

Testing Instructions

Modify the configuration.php file and include the following lines:

  public $session_redis_server_host = 'redis-server-url';
  public $session_redis_server_port = '6379';

Expected result

Sessions are stored in Redis and slight performance improvement when used in conjunction with Redis Cache.

Actual result

Session management is done by Redis and will work in a clustered environment without using database session handler.

Documentation Changes Required

Modify configuration.php

  public $session_redis_server_host = 'redis-server-url';
  public $session_redis_server_port = '6379';
avatar jdolinski jdolinski - open - 18 Apr 2017
avatar jdolinski jdolinski - change - 18 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2017
Category Administration com_config Language & Strings Libraries
avatar zero-24 zero-24 - change - 18 Apr 2017
Labels Added: ? ?
avatar jdolinski jdolinski - change - 18 Apr 2017
Title
Added Redis session handler support
Add Redis Session Support
avatar jdolinski jdolinski - edited - 18 Apr 2017
avatar jdolinski jdolinski - change - 18 Apr 2017
Title
Added Redis session handler support
Add Redis Session Support
91c41c8 18 Apr 2017 avatar zero-24 drone
avatar mbabker mbabker - test_item - 29 Jul 2017 - Tested successfully
avatar mbabker
mbabker - comment - 29 Jul 2017

I have tested this item successfully on a05a4e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15390.

avatar mbabker
mbabker - comment - 29 Jul 2017

If you're a Mac user running Homebrew for PHP, this is actually pretty easy to test.

brew install redis
brew install phpxx-redis (replace xx with the PHP version you're using)
brew services start redis

Then get into global config, change the session handler (default settings are fine), save, and validate that things work using Redis as a session backend.

I'm comfortable merging based on my test, but it'd be nice if someone else could also do so.

avatar alikon alikon - test_item - 30 Jul 2017 - Tested successfully
avatar alikon
alikon - comment - 30 Jul 2017

I have tested this item successfully on a05a4e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15390.

but we still need to manage situation like mod_status that directly access to the #__session table https://github.com/joomla/joomla-cms/blob/staging/administrator/modules/mod_status/mod_status.php#L33

avatar mbabker mbabker - change - 30 Jul 2017
Labels Added: ?
Removed: ?
avatar mbabker
mbabker - comment - 30 Jul 2017

but we still need to manage situation like mod_status that directly access to the #__session table

It's fine for now because of the app code that arbitrarily writes stuff to the session table even if the database session handler isn't in use.

avatar wilsonge wilsonge - change - 30 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-30 20:45:55
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Jul 2017
avatar wilsonge wilsonge - merge - 30 Jul 2017

Add a Comment

Login with GitHub to post a comment