Feeling Lucky
?
?
[#15385] - Add useragent for update calls
- Fixed in Code Base
- 11 Jul 2017
- Medium
- Build: staging
- # 15385
- Diff
- zero-24:useragent_updater
- Success hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #15381
Summary of Changes
Add useragent for update calls
Testing Instructions
test 1
- install a outdated extension
- apply this patch
- run the update
- confirm everything works
test 2
- install a outdated joomla version
- patch the file manually
- update to the last joomla version
Expected result
Update works with the useragent checks
Actual result
Update works but have no useragent
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
roland-d
- comment
- 10 Jul 2017
I have tested this item
Before the patch there is no user agent in the request:
"GET /rep/extension.xml HTTP/1.1" 200 720 "-" "-"
After the request the user agent is present:
"GET /rep/extension.xml HTTP/1.1" 200 720 "-" "Mozilla/5.0 Joomla!/3.7.4-dev Joomla"
Works great :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15385.
Quy
- comment
- 10 Jul 2017
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 10 Jul 2017
RTC as stated above.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-11 14:13:34 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
As from original #15381 I've tested by the following tests:
Result for the installation with changes receives the ok from the server (Code 200) with a defined User Agent (Mozilla/5.0 Joomla!/3.6.5 Joomla) . From Apache logs:
The Joomla install without modification receives an error 403 and no user agent at all. Again Apache log:
Good Work!