? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
18 Apr 2017

Pull Request for Issue # .

Summary of Changes

Just deprecating a method

Testing Instructions

None

Expected result

Actual result

Documentation Changes Required

avatar dgt41 dgt41 - open - 18 Apr 2017
avatar dgt41 dgt41 - change - 18 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2017
Category Libraries
avatar zero-24
zero-24 - comment - 18 Apr 2017

As we are now in code freeze this needs to wait until 3.7.1.

avatar zero-24 zero-24 - change - 18 Apr 2017
Status Pending Ready to Commit
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 18 Apr 2017

RTC for 3.7.1 Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15383.

avatar brianteeman
brianteeman - comment - 18 Apr 2017

as its only a comment and not actual code I dont see why it needs to wait ;)

avatar mbabker
mbabker - comment - 18 Apr 2017

Technically it would have to be 3.8 if it doesn't go into 3.7. Semantic Versioning disallows deprecating API functionality in a patch release.

avatar C-Lodder
C-Lodder - comment - 18 Apr 2017

@dgt41 - could you also add the deprecation notice for typeahead too please?

avatar dgt41 dgt41 - change - 18 Apr 2017
Labels
avatar zero-24
zero-24 - comment - 18 Apr 2017

@dgt41 can you please rebase against 3.8-dev so we can merge it for 3.8 ? Just ping me if done.

avatar dgt41
dgt41 - comment - 18 Apr 2017

@C-Lodder done. What is the plan the tooltips-extended, keep/drop?

avatar C-Lodder
C-Lodder - comment - 18 Apr 2017

tooltips-extended isn't neded in J4, so we can deprecate this too

avatar mbabker
mbabker - comment - 18 Apr 2017

I just merged staging to 3.8 and changed this PR's branch to 3.8-dev so we're good here. Once the tooltip thing is added I can merge this.

avatar dgt41 dgt41 - change - 18 Apr 2017
Labels Added: ?
Removed: ?
avatar zero-24 zero-24 - change - 18 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-18 16:27:24
Closed_By zero-24
avatar zero-24 zero-24 - close - 18 Apr 2017
avatar zero-24 zero-24 - merge - 18 Apr 2017
avatar zero-24
zero-24 - comment - 18 Apr 2017

Merged Thanks!

Add a Comment

Login with GitHub to post a comment