? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
18 Apr 2017

Pull Request for Issue #15342

Summary of Changes

This PR is a temporary fix to prevent the BS popovers from hanging over the viewport. BS are probably moving away from Tether in favour of popper.js

It also uses the correct options based on: http://v4-alpha.getbootstrap.com/components/popovers/

Testing Instructions

Ensure Popovers appear on the left if there isn't enough space to display it on the right.

avatar C-Lodder C-Lodder - open - 18 Apr 2017
avatar C-Lodder C-Lodder - change - 18 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2017
Category Libraries
avatar C-Lodder C-Lodder - change - 18 Apr 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Apr 2017

work on right Side (like sown in #15342), not left Side:
bildschirmfoto 2017-04-18 um 15 44 39

avatar C-Lodder
C-Lodder - comment - 18 Apr 2017

@franz-wohlkoenig - literally just fixed this. should work now

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Apr 2017

Test in Firefox, Chrome + Safari: Left Side Popovers hang over.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2017
Category Libraries Libraries Unit Tests
avatar C-Lodder
C-Lodder - comment - 18 Apr 2017

@franz-wohlkoenig - which page?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Apr 2017

In open Article Popover at "Category" (...) "Version Note" is shown left, only "Status" is shown right:
bildschirmfoto 2017-04-18 um 15 51 19

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Apr 2017

Page: Article-Categories > Alias-Popover.

avatar C-Lodder
C-Lodder - comment - 18 Apr 2017

yes, that's because there is still enough space for it. If only displays on the left if there isn't enough space.

avatar C-Lodder C-Lodder - change - 18 Apr 2017
Labels Added: ?
fffc484 18 Apr 2017 avatar C-Lodder tests
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 18 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Apr 2017

I have tested this item successfully on d5da507


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15377.

avatar wilsonge wilsonge - close - 18 Apr 2017
avatar wilsonge wilsonge - merge - 18 Apr 2017
avatar wilsonge wilsonge - change - 18 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-18 17:24:45
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment