? Pending

User tests: Successful: Unsuccessful:

avatar yasirunilan
yasirunilan
17 Apr 2017

Pull Request for Issue #15340 .

Summary of Changes

Added the space between Menu item name and description

Testing Instructions

Apply the patch and test

Expected result

menu item space new

Actual result

menu item space old

Documentation Changes Required

None

avatar yasirunilan yasirunilan - open - 17 Apr 2017
avatar yasirunilan yasirunilan - change - 17 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2017
Category Administration com_menus
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Apr 2017
Title
added space between menu item and description
[4.0] added space between menu item and description
Priority Medium Low
Easy No Yes
avatar joomla-cms-bot joomla-cms-bot - edited - 17 Apr 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Apr 2017
Category Administration com_menus Administration com_menus Templates (admin)
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2017
Category Administration com_menus Templates (admin) Administration com_menus
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 17 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Apr 2017

I have tested this item successfully on 4d2703d

@yasirunilan if you open a PR an Issue is created automatically. .github/CONTRIBUTING.md: "so you do not have to create an issue if you are creating a pull request."


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15341.

avatar yasirunilan
yasirunilan - comment - 17 Apr 2017

@franz-wohlkoenig got it .Thanks

avatar RonakParmar RonakParmar - test_item - 17 Apr 2017 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 17 Apr 2017

I have tested this item successfully on 4d2703d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15341.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Apr 2017

RTC after two successful tests.

avatar C-Lodder
C-Lodder - comment - 17 Apr 2017

@franz-wohlkoenig - again, wait :)

@yasirunilan - you've added padding in every direction. You only need right padding.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Apr 2017
Status Ready to Commit Pending
avatar yasirunilan
yasirunilan - comment - 17 Apr 2017

@C-Lodder did the change.

avatar RonakParmar RonakParmar - test_item - 17 Apr 2017 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 17 Apr 2017

I have tested this item successfully on c653fff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15341.

avatar rjcf18 rjcf18 - test_item - 17 Apr 2017 - Tested successfully
avatar rjcf18
rjcf18 - comment - 17 Apr 2017

I have tested this item successfully on c653fff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15341.

avatar wilsonge wilsonge - change - 17 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-17 18:17:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Apr 2017
avatar wilsonge wilsonge - merge - 17 Apr 2017
avatar wilsonge
wilsonge - comment - 17 Apr 2017

Thankyou!

Add a Comment

Login with GitHub to post a comment