User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This is a propose fix for default $prefix parameter use in MvcFactory in Joomla 4. I know this is an ugly fix but could not find a better solution because we have to keep B/C with legacy MVC.
This needs code review and decision from Joomla 4 team.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
Could you please try to download latest version here https://github.com/joomla/joomla-cms/tree/4.0-dev , then install and test it again? I could not re-procedure this issue
Installed new using https://github.com/joomla/joomla-cms/tree/4.0-dev and Sample Content – same Error is showing after "Save" an Sample-Article.
@franz-wohlkoenig You are correct. This is a typo (unrelated to this PR) and should be fixed with #15346
@franz-wohlkoenig Could you please open a new issue for that, please? Saving tag error should be a separate PR
Now that is fixed doesit work?
@franz-wohlkoenig Could you perform a full test as described in the test instructions? Need to test add/edit/delete/publish/unpublish in both com_content and com_contact
I think you can ignore that select user step. Edit an article, save it, if the change is saved, then it works OK
Then try to delete an article, publish an article, unpublish.
Do the same for com_contact. If it works well, then the test is success
Sorry for an unclear test instructions
@joomdonation Article: Changed Title
and a Word in Fulltext > Title is saved, Fulltext not (using Default-Editor > TinyMCE).
Thanks @franz-wohlkoenig . I guess this issue happens with and without this PR, so if it is possible, please open a separate issue for it
Thanks. If you can perform the same test with com_contact, that would be great
Com_contact works on delete/publish/unpublish/archived as expected.
OK. Thanks. You can mark the test as success. I will need to ask for code review / decision from Joomla 4 team with this change
I have tested this item
Easy | No | ⇒ | Yes |
Thanks again @franz-wohlkoenig
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-22 15:42:13 |
Closed_By | ⇒ | wilsonge |
Thanks ;)
Thankyou :)
I also changed default prefix for Table object, too. I have to set it to Table for legacy factory to keep B/C. I don't understand why the legacy method MVC default it to Table, it makes every model has to override getTable method like this https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_banners/models/banner.php#L282
If it is allowed to break B/C, we should change that default prefix to ucfirst(substr($option, 4)).'Table'. If we can do that, even component which use none namespace MVC can remove the method getTable from it's Model classes.