? Pending

User tests: Successful: Unsuccessful:

avatar rjcf18
rjcf18
16 Apr 2017

Pull Request for Issue #14742 .

Summary of Changes

Fixed the misalignment both in the Fields view and Field Groups view, shifted the filterform to the right alongside the other filterforms from the search tools bar in order to be more organized and fix the misalignment. Not sure if this is the right solution that was expected but solves the problem and organizes the filterforms in the same place.

Testing Instructions

Go to Content -> Fields or Content -> Field Groups and check if the articles filterform is in the far right next to the other filterforms from the search tools bar.

Expected result

Articles filterform on the far right next to other filterforms from the search tools bar:

Fields view:
deepinscreenshot20170416212455

Field groups view:
deepinscreenshot20170416212523

Actual result

Articles filterform on the left misaligned from the search tools bar.

Fields view:
deepinscreenshot20170416212811

Field groups:
deepinscreenshot20170416212828

Documentation Changes Required

None.

avatar rjcf18 rjcf18 - open - 16 Apr 2017
avatar rjcf18 rjcf18 - change - 16 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2017
Category Administration com_fields
avatar rjcf18 rjcf18 - change - 16 Apr 2017
The description was changed
avatar rjcf18 rjcf18 - edited - 16 Apr 2017
avatar rjcf18 rjcf18 - change - 16 Apr 2017
The description was changed
avatar rjcf18 rjcf18 - edited - 16 Apr 2017
avatar rjcf18 rjcf18 - change - 16 Apr 2017
Title
[4.0] [com_fields] Articles filterform dropdown fixed
[4.0] [com_fields] Articles filterform misalignment fixed
avatar rjcf18 rjcf18 - edited - 16 Apr 2017
avatar jreys jreys - test_item - 16 Apr 2017 - Tested successfully
avatar jreys
jreys - comment - 16 Apr 2017

I have tested this item successfully on 2243604


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15337.

avatar C-Lodder
C-Lodder - comment - 17 Apr 2017

Any reason why you've added the ordering-select class?

avatar yasirunilan yasirunilan - test_item - 17 Apr 2017 - Tested successfully
avatar yasirunilan
yasirunilan - comment - 17 Apr 2017

I have tested this item successfully on 2243604


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15337.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Apr 2017
Status Pending Ready to Commit
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Apr 2017

RTC after two successful tests.

avatar C-Lodder
C-Lodder - comment - 17 Apr 2017

@franz-wohlkoenig - wait. The ordering-select class still need to be removed.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Apr 2017
Status Ready to Commit Pending
avatar rjcf18
rjcf18 - comment - 17 Apr 2017

Yes you're right, it's not doing anything there, i'll make that change.

avatar wilsonge wilsonge - change - 17 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-17 10:33:26
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Apr 2017
avatar wilsonge wilsonge - merge - 17 Apr 2017
avatar wilsonge
wilsonge - comment - 17 Apr 2017

Thankyou :)

Add a Comment

Login with GitHub to post a comment