[#15330] - [4.0] Replaced remaining js alerts for joomla alerts for the toolbar buttons
- Fixed in Code Base
- 16 Apr 2017
- Medium
- Build: 4.0-dev
- # 15330
- Diff
- rjcf18:remaining-JSalerts-replaced
User tests: Successful: Unsuccessful:
Summary of Changes
As a followup to the Pull Request #15315 , besides the standard buttons I've noticed there were still buttons in the toolbar with the standard JS alert() on click when no item is selected, the batch button and the delete button, for instance, in Users. I've replaced the JS alert with the Joomla alert for those remaining buttons, I believe all buttons in the toolbar now have the Joomla alert on click when no item is selected.
Testing Instructions
Go to Banners and press Batch with no items selected and go to Users and press Delete with no items selected. In both cases you should see the Joomla alert instead of the JS alert().
Expected result
Toolbar buttons batch and toolbar standard buttons with a confirm dialog and Joomla alert on click.
Actual result
Toolbar buttons batch and toolbar standard buttons with a confirm dialog and standard JS alert() on click.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
| Category | Layout Libraries | ⇒ | Layout Libraries Unit Tests |
Oh right you're correct. Then how should I proceed here?
Should I replace the warning messages with error messages?
I think error makes more sense - shouldn't be hard to modify the existing PR to that :)
Sure, I'll make that change ;)
Thankyou very much :)
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-16 15:03:17 |
| Closed_By | ⇒ | wilsonge |
Good work :) Merged
Great! Thx! ;)
Oh missed one WARNING there in the standard buttons part in the JText::script(); here: https://github.com/joomla/joomla-cms/blob/2158be7540985775c48f66878a511cebad18f088/libraries/cms/toolbar/button/standard.php#L119
Should I do another PR to fix this? Sorry, totally missed it O.o
Ah ok thx ;) And thx to @NunoLopes69 for pointing out this improvement in the first place in his original PR :)
Is it really correct to say "warning"
Warning Message
A warning message is information displayed warning the user about risks associated with the use of the item and may include a requirement to confirm before proceeding
Error Message
An error message is information displayed when an unexpected condition occurs,