[#15322] - [4.0] Clean up MvcFactory
- Fixed in Code Base
- 16 Apr 2017
- Medium
- Build: 4.0-dev
- # 15322
- Diff
- joomdonation:mvc-factory-cleanup
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The current MVC factory implement completely ignore $prefix parameter. That result the code in backend cannot create MVC objects from frontend and vice versa. There are also several small clean up:
- Force table class to use Administrator namespace unless Site is directly passed
- Use correct CmsApplication class instead of it's alias JApplicationCms
Testing Instructions
Maybe code review would be enough. Or install Joomla 4 nightly, apply patch, play with com_content and make sure it still works as expected
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Administration com_content Libraries |
OK. I added some code to clean up methods parameters (makes it consistent with LegacyFactory), correct the order of the code to get Table + apply the fixes for com_content. Should be good to go now.
Looking better :) One last comment
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-16 15:40:13 |
| Closed_By | ⇒ | wilsonge |
Looks good to me :)
Thanks :)
Sorry. I didn't test the last minute Typo fix and didn't see this error. Figured out the reason of the error. There is a big in getName() method of Controller class and it causes this issue
It is corrected in my other PR #15301 , so please look at that PR when you have time
Actually, more than just that. View prefix is total difference with other type of MVC objects. Will need to think more about it to find a solution
I have tested this item✅ successfully on 586c7b5
I've navigated through the views at com_content added, edited, published, unpublished, archived, trashed and checked in several articles and categories, also featured and unfeatured several articles and there seems to be no problem, everything seems to be working fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15322.