?
avatar zero-24
zero-24
14 Apr 2017

Steps to reproduce the issue

https://travis-ci.org/joomla/joomla-cms/jobs/222075214

Expected result

Travis is happy

Actual result

Travis is not happy

avatar zero-24 zero-24 - open - 14 Apr 2017
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Apr 2017
avatar zero-24
zero-24 - comment - 14 Apr 2017
1) JPaginationTest::testListRender with data set #0 (array(array('<a title="JLIB_HTML_START" hr...RT</a>'), array('<a title="JPREV" href="" clas...EV</a>'), array('<a title="JNEXT" href="" clas...XT</a>'), array('<a title="JLIB_HTML_END" href...ND</a>'), array(array('<a href="" class="pagenav">1</a>'), array('<span class="pagenav">2</span>'), array('<a href="" class="pagenav">3</a>'), array('<a href="" class="pagenav">4</a>'))), 80, 20, 20, '<ul><li class="pagination-sta...></ul>')
Undefined index: active
/home/travis/build/joomla/joomla-cms/tests/unit/core/helper.php:52
/home/travis/build/joomla/joomla-cms/layouts/joomla/pagination/list.php:14
/home/travis/build/joomla/joomla-cms/libraries/cms/layout/file.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/layout/helper.php:72
/home/travis/build/joomla/joomla-cms/libraries/cms/pagination/pagination.php:693
/home/travis/build/joomla/joomla-cms/tests/unit/core/reflection.php:79
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/pagination/JPaginationTest.php:652
--
There were 4 failures:
1) JPaginationTest::testGetPagesLinks with data set #0 (100, 50, 20, '<ul><li class="pagination-sta...></ul>')
The expected output of the pagination is incorrect
Failed asserting that two DOM documents are equal.
--- Expected
+++ Actual
@@ @@
 <?xml version="1.0"?>
-<ul class="pagination ml-0 mb-4">
-  <li class="pagination-start page-item">
-    <a class="hasTooltip page-link" href="index.php?limitstart=0" title="JLIB_HTML_START">JLIB_HTML_START</a>
+<ul>
+  <li class="pagination-start">
+    <a class="hasTooltip pagenav" href="index.php?limitstart=0" title="JLIB_HTML_START">JLIB_HTML_START</a>
   </li>
-  <li class="pagination-prev page-item">
-    <a class="hasTooltip page-link" href="index.php?limitstart=20" title="JPREV">JPREV</a>
+  <li class="pagination-prev">
+    <a class="hasTooltip pagenav" href="index.php?limitstart=20" title="JPREV">JPREV</a>
   </li>
-  <li class="page-item ">
-    <a class="page-link" href="index.php?limitstart=0">1</a>
+  <li>
+    <a class="pagenav" href="index.php?limitstart=0">1</a>
   </li>
-  <li class="page-item ">
-    <a class="page-link" href="index.php?limitstart=20">2</a>
+  <li>
+    <a class="pagenav" href="index.php?limitstart=20">2</a>
   </li>
-  <li class="page-item disabled">
-    <span class="page-link">3</span>
+  <li>
+    <span class="pagenav">3</span>
   </li>
-  <li class="page-item ">
-    <a class="page-link" href="index.php?limitstart=60">4</a>
+  <li>
+    <a class="pagenav" href="index.php?limitstart=60">4</a>
   </li>
-  <li class="page-item ">
-    <a class="page-link" href="index.php?limitstart=80">5</a>
+  <li>
+    <a class="pagenav" href="index.php?limitstart=80">5</a>
   </li>
-  <li class="pagination-next page-item">
-    <a class="hasTooltip page-link" href="index.php?limitstart=60" title="JNEXT">JNEXT</a>
+  <li class="pagination-next">
+    <a class="hasTooltip pagenav" href="index.php?limitstart=60" title="JNEXT">JNEXT</a>
   </li>
-  <li class="pagination-end page-item">
-    <a class="hasTooltip page-link" href="index.php?limitstart=80" title="JLIB_HTML_END">JLIB_HTML_END</a>
+  <li class="pagination-end">
+    <a class="hasTooltip pagenav" href="index.php?limitstart=80" title="JLIB_HTML_END">JLIB_HTML_END</a>
   </li>
 </ul>
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/pagination/JPaginationTest.php:450
2) JPaginationTest::testItemActive with data set #0 ('JLIB_HTML_START', 100, 40, 20, false, '<a title="JLIB_HTML_START" hr...RT</a>')
The list render method is not outputting the expected results
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<a title="JLIB_HTML_START" href="" class="hasTooltip page-link">JLIB_HTML_START</a>'
+'<a title="JLIB_HTML_START" href="" class="hasTooltip pagenav">JLIB_HTML_START</a>'
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/pagination/JPaginationTest.php:702
3) JPaginationTest::testItemActive with data set #1 ('JLIB_HTML_VIEW_ALL', 100, 40, 20, false, '<a title="JLIB_HTML_VIEW_ALL"...LL</a>')
The list render method is not outputting the expected results
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<a title="JLIB_HTML_VIEW_ALL" href="" class="hasTooltip page-link">JLIB_HTML_VIEW_ALL</a>'
+'<a title="JLIB_HTML_VIEW_ALL" href="" class="hasTooltip pagenav">JLIB_HTML_VIEW_ALL</a>'
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/pagination/JPaginationTest.php:702
4) JPaginationTest::testItemInactive with data set #0 ('3', 100, 40, 20, false, '<span class="pagenav">3</span>')
The list render method is not outputting the expected results
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<span class="page-link">3</span>'
+'<span class="pagenav">3</span>'
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/pagination/JPaginationTest.php:749
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Apr 2017
Category Unit Tests
avatar joomdonation
joomdonation - comment - 16 Apr 2017

George fixed unit tests yesterday, Travis is happy now, so this issue can be closed

avatar zero-24
zero-24 - comment - 16 Apr 2017

Thanks

avatar zero-24 zero-24 - change - 16 Apr 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-04-16 10:34:26
Closed_By zero-24
avatar zero-24 zero-24 - close - 16 Apr 2017

Add a Comment

Login with GitHub to post a comment