[#15313] - Cleanup on an unused lang string related to com_banners
- Closed
- 15 Apr 2017
- Medium
- Build: staging
- # 15313
- Diff
- rjcf18:lang-strings-fix
User tests: Successful: Unsuccessful:
Summary of Changes
Deleted an unused language string (COM_BANNERS_BANNERS_NO_ITEM_SELECTED) due because there is another language string (COM_BANNERS_NO_BANNERS_SELECTED) with almost the exact same content that is in fact used elsewhere. The deleted one had "No Banners selected." and the one that is used and that remained had "No banners selected.".
Testing Instructions
You can see that the deleted language string is not used anywhere:
And the other similar language string is in fact used:
Expected result
No longer have an unused lang string while there is another that has the same content and that is used.
Actual result
An unused lang string alongside another lang string with the same content.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Oh ok I didn't know that sorry. Will take that into account from now on.
Sure I can do that. I can put something like ; This string is deprecated and will later be removed..
| Labels |
Added:
?
?
|
||
I've placed the comment to flag the lang string as deprecated.
Ah ok sure.
https://github.com/joomla/joomla-cms/blob/staging/libraries/legacy/controller/admin.php#L120 This string is used through a concat of the prefix here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_banners/controllers/banners.php#L27
Tbh this should always be picked up by the javascript in the backend. But if somehow it gets forced through server side then this string will be used.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-15 22:22:42 |
| Closed_By | ⇒ | wilsonge |
For long and boring reasons it is not our practice to delete unused strings.