Feeling Lucky
?
[#15309] - Fixed wrong data type declaration
- Fixed in Code Base
- 16 Apr 2017
- Medium
- Build: staging
- # 15309
- Diff
- demis-palma:updater-1
User tests: Successful: Unsuccessful:
$current_update is declared as JUpdate, but actually it's a JTableUpdate instead.
If it was a JUpdate, the subsequent calls to properties $current_update->extra_query and $current_update->version would cause a fatal error, since they are protected properties.
It can be verified with the help of a the debugger.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
mbabker
- comment
- 14 Apr 2017
Yes that is correct. update_sites is an array of associative arrays and updates is an array of JTableUpdate instances.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-16 20:14:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 16 Apr 2017
Dunno if someone wants to amend the class properties in those two classes to be JTableUpdate[]
Is this the actual type? As we just return arrays in that method?
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/updater/adapters/collection.php#L253
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/updater/adapters/extension.php#L357