@ryandemmer please take a look into drone ;) http://213.160.72.75/joomla/joomla-cms/2741 Thanks!

@zero-24 I have no idea what it is on about.

FILE: /drone/src/github.com/joomla/joomla-cms/plugins/system/sef/sef.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 135 | ERROR | Opening parenthesis of a multi-line function call must be the
     |       | last content on the line
 142 | ERROR | Closing parenthesis of a multi-line function call must be on a
     |       | line by itself

You will have to rewrite this lines

$buffer = preg_replace_callback($regex, function ($match) use ($base, $protocols) {
	$data = array();
	foreach (explode(",", $match[1]) as $url)
	{
		$data[] = preg_replace('#(?!/|' . $protocols . '|\#|\')([^\s]+)\s+(.*)#', $base . '$1 $2', $url);
	}
	return ' srcset="' . implode(",", $data) . '"';
}, $buffer);

to something like

$buffer = preg_replace_callback(
	$regex,
	function ($match) use ($base, $protocols)
	{
		$data = array();
		foreach (explode(",", $match[1]) as $url)
		{
			$data[] = preg_replace('#(?!/|' . $protocols . '|\#|\')([^\s]+)\s+(.*)#', $base . '$1 $2', $url);
		}
		return ' srcset="' . implode(",", $data) . '"';
	},
	$buffer
);

@Bakual Done, but it's still not happy.

Style over substance as far as I'm concerned.

Done, but it's still not happy.

Codestyle is fine now. I've restarted drone as it had a hickup with JavaScript something. Now it looks fine.

Style over substance as far as I'm concerned.

To be fair, those lines weren't really easy to read. Not it's much clearer which parts belong together.
So the codestyle rule made sense here.

I have tested this item ✅ successfully on 1049e45

I have tested the edited sef.php-file and the srcset-images are working now!

@webfeuerflo can you please mark your Test at issue Tracker

I am new to github and not sure how to do that!

• Please open Issue Tracker
• Login with your github-Account
• Click on blue "Test this"-Button above Authors-Picture
• mark your Test as successfully
• hit "submit test result"

I have tested this item ✅ successfully on 1049e45

With new sef.php the srcset-images are displayed correctly. did not experience any other issues.

thank you :-)

RTC after two successful tests.

Thank you!

This modification causes doubled relative root path in the front of each image url in case image url already contains the relative root path. Please see #17919.

The foreach loop could be modified to check the URL for the root path, eg:

foreach (explode(",", $match[1]) as $url)
{
	if (strpos($url, $base) === false) {
		$url = preg_replace('#(?!/|' . $protocols . '|\#|\')([^\s]+)\s+(.*)#', $base . '$1 $2', $url);
	}
	$data[] = $url;
}

Could you create PR with this fix ?

Perfect!