[#15283] - cleanup Index.html
- Closed
- 25 Mar 2018
- Medium
- Build: staging
- # 15283
- Diff
- brianteeman:indexhtml
User tests: Successful: Unsuccessful:
remove index.html reference from com_contenthistory xml as there is no file
com_mailto
remove index.html reference from com_mailto xml as there is no file
remove admin folder reference as there is no folder
com_wrapper
rename metadata.xml to wrapper.xml
remove admin folder reference as there is no folder
Remove some index.html files that are not needed as the folder is not empty and thats the only reason we were keeping them in some folders
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory Front End com_mailto com_wrapper Layout Libraries |
| Title |
|
||||||
I thought we only had the top level ones where there was nothing else in the folder to force creating of the folder?
I can see why we need top level ones where there would be no files only folders - i didnt touch those
I cant see why we would need them if there are files and folder - those are the ones i touched
We'd have to test, but the top level stuff only had to actually exist in the patch/update packages when installing through the extension manager. So we might not even need those or the part of the build script marking those as required anymore.
| Labels |
Added:
?
|
||
Did anyone run any build tests on this?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-14 19:53:39 |
| Closed_By | ⇒ | brianteeman |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-06-14 19:53:39 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
On principle I agree with this but I need to test with a test package to ensure removing the index.html files from top level directories doesn't cause an issue with updates (it shouldn't, that was a mostly artificial requirement from updates with the Extension Manager, but better safe than sorry).
Was'nt the top level index.html files needed when we have a release that is not touching this folders? (like 3.7.5)
And I will say again, that was explicitly because of the Extension Manager install path. We are not supporting that anymore, hence the reason this needs to be actively tested and not just either merged on a review or based on inline comments in the build script.
As this is !y pr I will take some time to use the build scripts to test. But the build script is pretty easy to use so please do that as well.
lost interest
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-25 14:30:39 |
| Closed_By | ⇒ | brianteeman |
The top level ones I think still need to exist for the build https://github.com/joomla/joomla-cms/blob/staging/build/build.php#L75-L88