[#15277] - [com_fields] Move the fields that are displayed "after content"
- Closed
- 14 Jun 2017
- Medium
- Build: staging
- Easy Test
- # 15277
- Diff
- brianteeman:fieldsaftercontent
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
this PR will move any field that is set to display "after content" to before any readmore link on a blog or featured article view
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Easy | No | ⇒ | Yes |
Dont we break the current behavior with onAfterDisplayContent with that change?
Dont we break the current behavior with onAfterDisplayContent with that change?
I wouldn't say it "breaks" something, but it will change the appearance if someone has a plugin installed which triggers on that event.
For example the voting information would be shown before the readmore button now if it is set to that position.
| Title |
|
||||||
| Title |
|
||||||
Now is logical, is ok for UIX, nothig after Readmore.
I hope in the future that custom fields can be displayed only in the complete article with a parameter option: After display, Before display or After Read more.
If, and IMO this is a big if, this PR is accepted it needs to be very well documented. It WILL change the output on sites using the core layouts.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15277.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Needs Review |
As @mbabker says this will change the output for current sites. I can't see a real need for doing so, setting it to needs review to get a bit more information and discuss this more
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15277.
| Labels |
Added:
?
|
||
set Status on "Needs Review" cause of above Comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15277.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15277.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15277.
| Status | Needs Review | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-14 19:53:38 |
| Closed_By | ⇒ | brianteeman |
I have tested this item✅ successfully on a5e0138
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15277.