? Pending

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
13 Apr 2017

Pull Request for Issue #15145

Summary of Changes

Allow backend menu module to still work with old (pre j37) database structure, i.e. without client_id column.

Testing Instructions

Install J3.5.1
Enable error reporting
Update it to 3.7 rc*
When update scripts asks for confirmation for update, there are notices at the top of page.
After this patch to the update package, there should be no notices.

Documentation Changes Required

None

avatar izharaazmi izharaazmi - open - 13 Apr 2017
avatar izharaazmi izharaazmi - change - 13 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2017
Category Modules Administration
avatar AlexRed AlexRed - test_item - 16 Apr 2017 - Tested unsuccessfully
avatar AlexRed
AlexRed - comment - 16 Apr 2017

I have tested this item ? unsuccessfully on bc54f8f

In my test, update a site from Joomla 3.4.8 to 3.7 rc* with your PR no more notices but some old and new error message:
Warning
JInstaller: :Install: SQL File Buffer Read Error.
Files Update: SQL error file DB function reports no errors.
Error loading component: com_fields, Component not found.
warning-fix-update

and the component menu is almost empty


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15275.
avatar mbabker
mbabker - comment - 17 Apr 2017

The "SQL File Buffer Read Error" is either a corrupt SQL update file or a local filesystem permissions issue. Unrelated to this PR.

Actually, none of your warning messages can be caused by this PR. Therefore, if you are no longer getting the Undefined property: stdClass::$client_id error message as noted in the original issue then this PR is successful for the issue it is aiming to address.

avatar AlexRed
AlexRed - comment - 17 Apr 2017

I use a custom xml update url to test the PR:
http://alexred.com/joomla/2017/next_minor_list.xml
You can try to find if there is a corrupt SQL update file. I edit the nightly update package like in this PR, rezip, and upload it on my server to test it in the update procedure.
If I use the original nightly update package no SQL File Buffer Read Error"

avatar rdeutz rdeutz - test_item - 18 Apr 2017 - Tested successfully
avatar rdeutz
rdeutz - comment - 18 Apr 2017

I have tested this item successfully on bc54f8f

A bit tricky to test, here is what I did:

  • Do an update without adding the patch and let the system run into the problem.
  • Replace the file administrator/modules/mod_menu/preset/enabled.php with the patched version
  • Reload the page

You will still see warnings but these have a different source.

Continue the update process


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15275.

avatar zero-24 zero-24 - test_item - 19 Apr 2017 - Tested successfully
avatar zero-24
zero-24 - comment - 19 Apr 2017

I have tested this item successfully on bc54f8f

Works great. Thanks.

@AlexRed please test it using the way @rdeutz posted above. THis way we are sure there is no Problem with your package ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15275.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Apr 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 19 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-19 18:25:09
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 19 Apr 2017
avatar rdeutz rdeutz - merge - 19 Apr 2017

Add a Comment

Login with GitHub to post a comment