? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
12 Apr 2017

Summary of Changes

Currently, the override creator only allows to create overrides for JLayouts located withing /layouts/joomla.
current

This PR changes the code so it can also create overrides for the other global JLayouts plus for JLayouts located within a component folder (compontens/com_foo/layouts).
new

Testing Instructions

  • Create various overrides for JLayouts as well as view ones
  • Adjust the created file a bit (you'll see the path to it in the success message) so you can see the override actually works

Expected result

  • You can create overrides for all global JLayouts as well as for component specific ones (eg com_fields)
  • Your changes in the created override will have an effect

Actual result

Only possible to create overrides for Jlayouts in /layouts/joomla

Documentation Changes Required

Not that I'm aware

Pinging @angieradtke

avatar Bakual Bakual - open - 12 Apr 2017
avatar Bakual Bakual - change - 12 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2017
Category Administration com_templates
avatar ot2sen ot2sen - test_item - 12 Apr 2017 - Tested successfully
avatar ot2sen
ot2sen - comment - 12 Apr 2017

I have tested this item successfully on f631ee3

Nice one. Seems to be working well.
Mistakenly did same create twice and nice to see the override system add a date/timestamp to the naming.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15268.
avatar brianteeman
brianteeman - comment - 12 Apr 2017

(creating backups with dated filenames is not new)

avatar laoneo
laoneo - comment - 13 Apr 2017

Nice thing. Thanks!

avatar angieradtke
angieradtke - comment - 13 Apr 2017

Cool, thank you

avatar ghazal ghazal - test_item - 14 Apr 2017 - Tested successfully
avatar ghazal
ghazal - comment - 14 Apr 2017

I have tested this item successfully on f631ee3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15268.

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Apr 2017

RTC after two successful tests.

avatar zero-24
zero-24 - comment - 14 Apr 2017

@rdeutz please take the desicion if this goes into 3.7.0 or 3.7.1.

avatar rdeutz rdeutz - change - 14 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-14 14:59:37
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 14 Apr 2017
avatar rdeutz rdeutz - merge - 14 Apr 2017
avatar angieradtke
angieradtke - comment - 14 Apr 2017

cool

Am 14.04.2017 um 16:59 schrieb Robert Deutz:

Merged #15268 #15268.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15268 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/ABHjs-RMLLVpt6pzIY1pqgCOw6VFLBscks5rv4ncgaJpZM4M769V.

Add a Comment

Login with GitHub to post a comment