? ? Pending

User tests: Successful: Unsuccessful:

avatar yvesh
yvesh
12 Apr 2017

Summary of Changes

Fixed the failing JModelList tests in 4.x branch.. Because we changed the class name from JModelList to ModelList the extension is now empty (instead of com_j before, now we have com_), this detection needs fixing in the Model itself.

Testing Instructions

Review travis is green, don't look at the code or you will cry (i just made it work again)

How you can test 15 times that the context is (magically) com_.listmodel is.. just don't look at the code please.

Going to rewrite the tests once we are nearer to an stable namespaced MVC layer..

Expected result

Travis passes

Actual result

Travis fails

Documentation Changes Required

none

avatar yvesh yvesh - open - 12 Apr 2017
avatar yvesh yvesh - change - 12 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2017
Category Unit Tests
avatar yvesh yvesh - change - 12 Apr 2017
The description was changed
avatar yvesh yvesh - edited - 12 Apr 2017
avatar wilsonge wilsonge - change - 13 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-13 08:30:12
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 13 Apr 2017
avatar wilsonge wilsonge - merge - 13 Apr 2017
avatar wilsonge
wilsonge - comment - 13 Apr 2017

Is this not a problem in 3.8?

avatar yvesh yvesh - change - 13 Apr 2017
The description was changed
avatar yvesh yvesh - edited - 13 Apr 2017

Add a Comment

Login with GitHub to post a comment