[#15258] - Ensure that InnoDB support is enable in MySQL
- Closed
- 1 Jul 2019
- Medium
- Build: staging
- # 15258
- Diff
- Supun94:issue#15189
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #15189 .
Summary of Changes
Installation freezing issue happens if user has not enabled InnoDB support in database platform. During the installation time check if InnoDB support is enabled or not. If disabled display an Error message.
Testing Instructions
- Disable InnoDB support in database platform and try 'Database Configuration' step and test.
- Enable InnoDB support and try the same step.
Expected result
- If disabled the InnoDB support you'll get an Error message 'You need to enable default InnoDB support in your database platform' and stay in the 'Database Configuration' step.
- If enabled the InnoDB support go to the next page.
Actual result
If InnoDB support is disabled in database platform, installation freezing issue (#15189) happened.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
@zero-24 fixed it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15258.
I have tested this item
Works good for me.
For anyone who wants to test this to enable myisam e.g. on xampp you need to add default-storage-engine = myisam in the mysql configuration file: http://stackoverflow.com/questions/3050492/how-can-i-set-default-storage-engine-used-by-mysql
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15258.
I have tested this item
Description of PR is OK but php code is wrong.
There is two different things:
- support for innoDB (in general)
- default storage engine as innoDB
I installed Joomla on localhost (mysql 5.7) with default-storage-engine = myisam without patch without any problems.
After patched I can not install Joomla anymore with mentioned configuration.
This PR should check if support for innoDB is enabled but
now php code checks if default storage engine is set as innoDB.
Solution, replace:
if ($value != 'DEFAULT')
to:
if ($value == 'NO')
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15258.
Screen-shot:
There is also engine MEMORY which support is required.
I have tested this item
I tested only when InnoDB is supported as not default engine and it is OK.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15258.
@zero-24 can you please retest?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15258.
May be there is someone who can do Joomla test installation on mysql with at least InnoDB enabled (by default).
I tried to test but I only have mysql 5.7 and it is not possible to disable innodb with 5.7
@brianteeman IMO is enough to make a review and check if it does not break anything on mysql with enabled InnoDB.
Otherwise, I do not see any future of this PR.
Perhaps but I will never personally mark that I have tested something and it is working unless I can replicate the problem
On mysql 5.7, it can not be replicated. InnoDB can be disabled on mysql <=5.6.21 only.
https://dev.mysql.com/doc/refman/5.6/en/innodb-turning-off.html
and thats exactly why i cannot test it
| Category | Installation Language & Strings | ⇒ | Installation |
| Title |
|
||||||
| Category | Installation | ⇒ | Installation Language & Strings |
Hi @Supun94,
thanks for the time you invested into this PR but I think there are some flaws in it (ex. works only for mysql driver and not for mysqli and pdo). Anyway in the meantime the mysql version in which you can disable InnoDB is EOL. That means check this makes less sense anymore.
But if you like to bring your PR up to date and support the other mysql drivers we can reevaluate it.
In the meantime I'm closing this PR, you can reopen it anytime.
thx for trying to make Joomla! more robust.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-01 22:32:29 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Removed:
J3 Issue
|
||
Hi @Supun94 can you take a look into the drone report: http://213.160.72.75/joomla/joomla-cms/2665 ?