? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
12 Apr 2017

Pull Request for Issue #15243.

Summary of Changes

Adds the readonly code also to the "legacy" mode in TinyMCE

Testing Instructions

  • I'm not exactly sure how to get into that legacy mode. I guess it's after an update from 3.6.5 as long as you didn't save the tinymce editor plugin options.
  • Create an article or category (or any other place that has an editor)

Expected result

Empty editor field

Actual result

The editor field contains a notice about an undefined property "$readonly".

Documentation Changes Required

None

avatar Bakual Bakual - open - 12 Apr 2017
avatar Bakual Bakual - change - 12 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2017
Category Front End Plugins
avatar AlexRed
AlexRed - comment - 12 Apr 2017

I extract Joomla_3.7.0-rc2-Release_Candidate-Update_Package.zip
edit the file plugins/editors/tinymce/tinymce.php
zip the package and use it on a Joomla 3.6.5 fresh install in the Joomla Update component.
But some notice and error
error-buffer

avatar Bakual
Bakual - comment - 12 Apr 2017

This PR certainly shouldn't generate the errors you get. That must be something else.

avatar Bakual Bakual - change - 12 Apr 2017
Labels Added: ?
avatar jsubri jsubri - test_item - 17 Apr 2017 - Tested successfully
avatar jsubri
jsubri - comment - 17 Apr 2017

I have tested this item successfully on c581acd

This PR fixed the "Notice: Undefined property: stdClass::$readonly" using Multilingual Associations: Edit Associations (Articles > Categories)
Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15254.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 17 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Apr 2017

I have tested this item successfully on c581acd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15254.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Apr 2017
Status Pending Ready to Commit
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Apr 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 18 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-18 06:45:34
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 18 Apr 2017
avatar rdeutz rdeutz - merge - 18 Apr 2017

Add a Comment

Login with GitHub to post a comment