? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
12 Apr 2017

Move JSearchHelper to namespace. I'v also cleaned up some code in the search helper class, to make it more readable.

ae74372 12 Apr 2017 avatar laoneo CS
avatar laoneo laoneo - open - 12 Apr 2017
avatar laoneo laoneo - change - 12 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2017
Category Administration com_search Front End com_finder Libraries
avatar wilsonge
wilsonge - comment - 12 Apr 2017

Can we do the code cleanup separately to the namespacing please? Because github now doesn't recognise this as a file move - plus it's much harder for me to review

avatar laoneo laoneo - change - 12 Apr 2017
Labels Added: ?
avatar laoneo
laoneo - comment - 12 Apr 2017

Reverted

avatar wilsonge wilsonge - change - 12 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-12 12:32:16
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Apr 2017
avatar wilsonge wilsonge - merge - 12 Apr 2017
avatar wilsonge
wilsonge - comment - 12 Apr 2017

Thankyou - sorry to be a pain about it!

avatar laoneo
laoneo - comment - 12 Apr 2017

No problem, better to stay on the safe side :-)

Add a Comment

Login with GitHub to post a comment