[#15229] - [com_fields] Set the language on the contact form data
- Fixed in Code Base
- 14 Apr 2017
- Medium
- Build: staging
- # 15229
- Diff
- Digital-Peak:cf/contact-language
User tests: Successful: Unsuccessful:
Pull Request for comment #15223 (comment) .
Summary of Changes
On multilanguage sites when a user open the contact form page, only fields should be displayed which do belong to the actual language.
Testing Instructions
- Install a fresh joomla without sample data but with multilanguage. Select some additional languages to install.
- Create a Contact -> Mail field and assign it to a language which is not en-GB.
- Create a contact.
- Create a "Single Contact" menu item.
- On the front make sure you open the page with the English language.
- Click in the contact menu link.
Expected result
No field is shown.
Actual result
The field is shown which does not belong to the English language.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15229.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Folks, I really disagree with this PR as it does not check if the site is multilingual, without any message.
It would be the only place in Joomla where some stuff would be filtered by language on a monolanguage site.
I am changing the RTC status to Need Review for maintainers to decide.
| Status | Ready to Commit | ⇒ | Needs Review |
@infograf768 I asked you why you want to do this change but you didn't answer. It's not that I don't want to change it, more that I want to know the reason as it has the same effect on a single language site as on a multilanguage one. Just wanted to avoid an extra function call, which is IMO not necessary.
sorry if I did not reply. It for the same reasons I explained here:
#14865 (comment)
and for the same reasons, I made this #15297 to correct your other PR for registration
Again:
It would be the only place in Joomla where some stuff would be filtered by language on a monolanguage site.
| Labels |
Added:
?
|
||
Changed.
| Status | Needs Review | ⇒ | Ready to Commit |
RTC again as easy change. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15229.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-14 10:47:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 665fef7
Patch ok for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15229.