Edit a category.
Go to Permissions tab.
If you do see an active active, close it and try a different record.
Other Permissions sections are affected too.
In Firebug, you can see no active
class.
Tested in Firefox 53.0, Chrome 58.0.30, and Edge 38.143 in Windows 10 Home.
Labels |
Added:
?
|
Title |
|
Category | ⇒ | ACL com_categories |
Title |
|
Status | New | ⇒ | Closed - Unconfirmed Report |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-11 05:35:43 |
Closed_By | ⇒ | franz-wohlkoenig |
Title |
|
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15214
Status | Closed - Unconfirmed Report | ⇒ | New |
Closed_Date | 2017-04-11 05:35:43 | ⇒ | |
Closed_By | franz-wohlkoenig | ⇒ |
Closed_Date | 0000-00-00 00:00:00 | ⇒ |
Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15214
Latest staging version as 4/11.
Rel_Number | 0 | ⇒ | 13572 |
Relation Type | ⇒ | Related to |
Status | New | ⇒ | Discussion |
If you have any issues for J4, please be sure to put [4.0] before the title so they can easily be found.
I guess my change only revealed another issue. Since previously, the tabstate once set would be present in eternity, now you get the effect each time after you have closed the browser. The issue was probably there before, but only once and you don't remember it anymore.
Imho, the permissions should activate a tab by default which then is changed later by the script (if a state is stored). Instead, no tab is active by default which is the real issue here.
The following code sets the initial active default tab, but tabstate clears it I assume.
foreach ($groups as $group)
{
// Initial Active Tab
$active = "";
if ($group->value == 1)
{
$active = "active";
}
$html[] = '<li class="' . $active . '">';
$html[] = '<a href="#permission-' . $group->value . '" data-toggle="tab">';
$html[] = str_repeat('<span class="level">–</span> ', $curLevel = $group->level) . $group->text;
$html[] = '</a>';
$html[] = '</li>';
}
Hmm, it may be related to #12503 then, as that one actually changed the JS. My PR only changed the storage place an shouldn't have such side effects.
After playing around a bit, it looks like the page stores two different tab states, once for the main tabs and another one for the permission tab. They may overwrite eachother if I see that right since they both use the same key.
@dgt41 That PR was from you, can you have a look?
@dgt41 Looks like it uses the same key as the tabs from the edit form itself, but the value is eg ["#permission-6"]
instead of the ["#page-permissions"]
from the edit form. They indeed overwrite eachother now. So i think we need a way for the permission tabs to have a different key than the edit form itself. Same issue would happen to any form where there are multiple tabs.
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-03 10:25:45 |
Closed_By | ⇒ | franz-wohlkoenig |
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-03 10:25:45 |
Closed_By | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15214
closed as having PR #15748
Can't confirm Issue: