?
Related to # 13572
avatar Quy
Quy
11 Apr 2017

Steps to reproduce the issue

Edit a category.
Go to Permissions tab.
If you do see an active active, close it and try a different record.
Other Permissions sections are affected too.

permissions-no-active
In Firebug, you can see no active class.
permissions-firebug

Additional comments

Tested in Firefox 53.0, Chrome 58.0.30, and Edge 38.143 in Windows 10 Home.

avatar Quy Quy - open - 11 Apr 2017
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Apr 2017
avatar Quy Quy - edited - 11 Apr 2017
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2017
Title
No active active in Permissions
No active class in Permissions
avatar joomla-cms-bot joomla-cms-bot - edited - 11 Apr 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2017
Category ACL com_categories
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Apr 2017

Can't confirm Issue:
bildschirmfoto 2017-04-11 um 07 32 00

avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2017
Title
No active class in Permissions
No active active in Permissions
avatar joomla-cms-bot joomla-cms-bot - edited - 11 Apr 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2017
Status New Closed - Unconfirmed Report
Closed_Date 0000-00-00 00:00:00 2017-04-11 05:35:43
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2017
Title
No active active in Permissions
No active class in Permissions
avatar joomla-cms-bot joomla-cms-bot - close - 11 Apr 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 11 Apr 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2017
Status Closed - Unconfirmed Report New
Closed_Date 2017-04-11 05:35:43
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2017
Closed_Date 0000-00-00 00:00:00
avatar joomla-cms-bot joomla-cms-bot - reopen - 11 Apr 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 11 Apr 2017
avatar C-Lodder
C-Lodder - comment - 11 Apr 2017

@Quy - is your issue regarding Joomla 3.6.5 or 3.7.0-rc1?

avatar Quy
Quy - comment - 11 Apr 2017

Latest staging version as 4/11.

avatar Quy
Quy - comment - 21 Apr 2017

This issue is related to PR #13572. Reverted tabs-state.js from v3.6.5 and it fixed this issue.

avatar Quy Quy - edited - 21 Apr 2017
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 21 Apr 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Apr 2017
Rel_Number 0 13572
Relation Type Related to
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 21 Apr 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Apr 2017
Status New Discussion
avatar C-Lodder
C-Lodder - comment - 21 Apr 2017

If you have any issues for J4, please be sure to put [4.0] before the title so they can easily be found.

avatar Quy
Quy - comment - 21 Apr 2017

It is for v3.7.

@Bakual Please confirm issue. Thanks.

avatar Bakual
Bakual - comment - 21 Apr 2017

I guess my change only revealed another issue. Since previously, the tabstate once set would be present in eternity, now you get the effect each time after you have closed the browser. The issue was probably there before, but only once and you don't remember it anymore.

Imho, the permissions should activate a tab by default which then is changed later by the script (if a state is stored). Instead, no tab is active by default which is the real issue here.

avatar Quy
Quy - comment - 21 Apr 2017

The following code sets the initial active default tab, but tabstate clears it I assume.

        foreach ($groups as $group)
        {
            // Initial Active Tab
            $active = "";

            if ($group->value == 1)
            {
                $active = "active";
            }

            $html[] = '<li class="' . $active . '">';
            $html[] = '<a href="#permission-' . $group->value . '" data-toggle="tab">';
            $html[] = str_repeat('<span class="level">&ndash;</span> ', $curLevel = $group->level) . $group->text;
            $html[] = '</a>';
            $html[] = '</li>';
        }
avatar Bakual
Bakual - comment - 21 Apr 2017

Hmm, it may be related to #12503 then, as that one actually changed the JS. My PR only changed the storage place an shouldn't have such side effects.

After playing around a bit, it looks like the page stores two different tab states, once for the main tabs and another one for the permission tab. They may overwrite eachother if I see that right since they both use the same key.
@dgt41 That PR was from you, can you have a look?

avatar dgt41
dgt41 - comment - 21 Apr 2017

@Bakual is the id the same for all instances of permissions?
If so we can add some more logic to the script to manage this case.
I will look at this tonight

avatar Bakual
Bakual - comment - 21 Apr 2017

@dgt41 Looks like it uses the same key as the tabs from the edit form itself, but the value is eg ["#permission-6"] instead of the ["#page-permissions"] from the edit form. They indeed overwrite eachother now. So i think we need a way for the permission tabs to have a different key than the edit form itself. Same issue would happen to any form where there are multiple tabs.

avatar PhilETaylor
PhilETaylor - comment - 3 May 2017

Fixed with #15748 please test

avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 3 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 May 2017
The description was changed
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-05-03 10:25:45
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-05-03 10:25:45
Closed_By joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 3 May 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 3 May 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 May 2017

closed as having PR #15748


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15214.

Add a Comment

Login with GitHub to post a comment